Move topgear billing account ids to the environment variables

Author: marioskranitsas

app-constants.js

@@ -18,11 +18,6 @@ const prizeSetTypes = {
   CheckpointPrizes: 'checkpoint'
 }
 
-const topGearBillingAccounts = [
-  '80000062',
-  '80002800'
-]
-
 const challengeStatuses = {
   New: 'New',
   Draft: 'Draft',
@@ -145,6 +140,5 @@ module.exports = {
   DiscussionTypes,
   reviewTypes,
   SelfServiceNotificationTypes,
-  SelfServiceNotificationSettings,
-  topGearBillingAccounts
+  SelfServiceNotificationSettings
 }

config/default.js

@@ -73,6 +73,9 @@ module.exports = {
   OBSERVER_ROLE_ID: process.env.OBSERVER_ROLE_ID || '2a4dc376-a31c-4d00-b173-13934d89e286',
   CLIENT_MANAGER_ROLE_ID: process.env.OBSERVER_ROLE_ID || '9b2f1905-8128-42da-85df-ed64410f4781',
 
+  // topgear billing accounts
+  TOPGEAR_BILLING_ACCOUNTS_ID: process.env.TOPGEAR_BILLING_ACCOUNTS_ID ? process.env.TOPGEAR_BILLING_ACCOUNTS_ID.split(',') : [],
+
   // health check timeout in milliseconds
   HEALTH_CHECK_TIMEOUT: process.env.HEALTH_CHECK_TIMEOUT || 3000,
 

src/services/ChallengeService.js

@@ -1491,7 +1491,7 @@ async function update (currentUser, challengeId, data, isFull) {
     _.set(data, 'billing.billingAccountId', billingAccountId)
     _.set(data, 'billing.markup', markup || 0)
   }
-  if (billingAccountId && _.includes(constants.topGearBillingAccounts, _.toString(billingAccountId))) {
+  if (billingAccountId && _.includes(config.TOPGEAR_BILLING_ACCOUNTS_ID, _.toString(billingAccountId))) {
     if (_.isEmpty(data.metadata)) {
       data.metadata = []
     }