refactor handlePhasesAfterCancelling

Author: ThomasKranitsas

src/common/phase-helper.js

@@ -172,13 +172,12 @@ class ChallengePhaseHelper {
 
   handlePhasesAfterCancelling(phases) {
     return _.map(phases, (phase) => {
-      if (_.includes(["Registration", "Submission", "Checkpoint Submission"], phase.name)) {
-        phase.isOpen = false;
-        if (!_.isUndefined(phase.actualStartDate)) {
-          phase.actualEndDate = moment().toDate().toISOString();
-        }
-      }
-      return phase;
+      const shouldClosePhase = _.includes(["Registration", "Submission", "Checkpoint Submission"], phase.name);
+      return {
+        ...phase,
+        isOpen: shouldClosePhase ? false : phase.isOpen,
+        actualEndDate: shouldClosePhase ? moment().toDate().toISOString() : phase.actualEndDate,
+      };
     });
   }
 

src/services/ChallengeService.js

@@ -42,6 +42,7 @@ const {
   convertToISOString,
 } = require("../common/challenge-helper");
 const deepEqual = require("deep-equal");
+const { cloneDeep } = require("lodash");
 
 const challengeDomain = new ChallengeDomain(GRPC_CHALLENGE_SERVER_HOST, GRPC_CHALLENGE_SERVER_PORT);