Skip to content

Commit a8d2143

Browse files
committed
fix: do not ignore scheduled start date
1 parent e4c580c commit a8d2143

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

src/common/phase-helper.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,6 @@ class ChallengePhaseHelper {
1313
* @param {String} timelineTemplateId the timeline template id
1414
*/
1515
async populatePhases (phases, startDate, timelineTemplateId) {
16-
console.log('populatePhases', phases, startDate, timelineTemplateId)
1716
if (_.isUndefined(timelineTemplateId)) {
1817
throw new errors.BadRequestError(`Invalid timeline template ID: ${timelineTemplateId}`)
1918
}
@@ -48,7 +47,6 @@ class ChallengePhaseHelper {
4847
throw new errors.BadRequestError(`Predecessor ${phaseTemplate.predecessor} not found in given phases.`)
4948
}
5049
p.predecessor = phaseTemplate.predecessor
51-
console.log('Setting predecessor', p.predecessor, 'for phase', p.phaseId)
5250
}
5351
}
5452
}
@@ -113,7 +111,9 @@ class ChallengePhaseHelper {
113111
p.scheduledStartDate = phaseEndDate.toDate()
114112
p.scheduledEndDate = moment(p.scheduledStartDate).add(p.duration, 'seconds').toDate()
115113
}
114+
116115
p.isOpen = moment().isBetween(p.scheduledStartDate, p.scheduledEndDate)
116+
117117
if (p.isOpen) {
118118
if (p.name === 'Submission') {
119119
isSubmissionPhaseOpen = true

src/services/ChallengeService.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2026,7 +2026,7 @@ function sanitizeChallenge (challenge) {
20262026
sanitized.metadata = _.map(challenge.metadata, meta => _.pick(meta, ['name', 'value']))
20272027
}
20282028
if (challenge.phases) {
2029-
sanitized.phases = _.map(challenge.phases, phase => _.pick(phase, ['phaseId', 'duration', 'isOpen', 'actualEndDate']))
2029+
sanitized.phases = _.map(challenge.phases, phase => _.pick(phase, ['phaseId', 'duration', 'isOpen', 'actualEndDate', 'scheduledStartDate']))
20302030
}
20312031
if (challenge.prizeSets) {
20322032
sanitized.prizeSets = _.map(challenge.prizeSets, prizeSet => ({

0 commit comments

Comments
 (0)