Skip to content

Commit 8b07c46

Browse files
committed
feat: update logging
1 parent 4b160ab commit 8b07c46

File tree

3 files changed

+15
-6
lines changed

3 files changed

+15
-6
lines changed

app-routes.js

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -108,7 +108,10 @@ module.exports = (app) => {
108108
}
109109
});
110110
}
111-
111+
actions.push((req, res, next) => {
112+
logger.info(`Done request handling, ${req.signature}`);
113+
next();
114+
});
112115
actions.push(method);
113116
app[verb](`/${config.API_VERSION}${path}`, helper.autoWrapExpress(actions));
114117
});

src/common/logger.js

Lines changed: 10 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -30,10 +30,16 @@ logger.logFullError = (err, signature) => {
3030
if (signature) {
3131
logger.error(`Error happened in ${signature}`);
3232
}
33-
logger.error(util.inspect(err));
34-
if (!err.logged) {
35-
logger.error(err.stack);
36-
err.logged = true;
33+
if (err.isJoi) {
34+
logger.error(
35+
`${e.name} details: ${JSON.stringify(e.details)} input:${JSON.stringify(e._object)}`
36+
);
37+
} else if (err.isAxiosError) {
38+
logger.error(`${err.message} - ${err.response.data}`);
39+
} else if (err.httpStatus) {
40+
logger.error(err.message);
41+
} else {
42+
logger.error(util.inspect(err));
3743
}
3844
};
3945

src/services/ChallengeService.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1420,7 +1420,7 @@ async function updateChallenge(currentUser, challengeId, data) {
14201420

14211421
// Remove fields from data that are not allowed to be updated and that match the existing challenge
14221422
data = sanitizeData(sanitizeChallenge(data), challenge);
1423-
console.debug("Sanitized Data:", data);
1423+
logger.debug("Sanitized Data:", JSON.stringify(data));
14241424

14251425
await validateChallengeUpdateRequest(currentUser, challenge, data);
14261426

0 commit comments

Comments
 (0)