feat: remove route transformer

Author: liuliquan

app-routes.js

@@ -10,22 +10,13 @@ const helper = require("./src/common/helper");
 const errors = require("./src/common/errors");
 const logger = require("./src/common/logger");
 const routes = require("./src/routes");
-const transformations = require("./src/common/transformations");
 const authenticator = require("tc-core-library-js").middleware.jwtAuthenticator;
 
 /**
  * Configure all routes for express app
  * @param app the express app
  */
 module.exports = (app) => {
-  app.use((req, res, next) => {
-    req.appVersion = req.headers["app-version"] || "1.0.0";
-    if (!transformations[req.appVersion]) {
-      req.appVersion = "1.0.0"; // default to 1.0.0 if provided version doesn't match any transformation
-    }
-    next();
-  });
-
   // Load all routes
   _.each(routes, (verbs, path) => {
     _.each(verbs, (def, verb) => {
@@ -45,42 +36,6 @@ module.exports = (app) => {
         next();
       });
 
-      if (def.versioned) {
-        actions.push((req, res, next) => {
-          // TODO: Overriding res.send is a temporary solution to inject version-based transformations.
-          // TODO: A more conventional approach in Express would be to use res.locals to pass data through middleware,
-          // TODO: and then send the response in a centralized middleware after all transformations are applied.
-          // TODO: This would require a refactor of the current controllers' response handling.
-          // TODO: Consider revisiting this implementation in the future for a more maintainable architecture.
-
-          const originalSend = res.send;
-          const originalStatus = res.status;
-          let currentStatusCode = 200; // Default status code for Express
-
-          // Override res.status to capture the status code
-          res.status = function (code) {
-            currentStatusCode = code;
-            return originalStatus.apply(this, arguments);
-          };
-
-          res.send = (data) => {
-            // If the status code indicates a successful response, apply the transformation
-            if (currentStatusCode >= 200 && currentStatusCode < 300) {
-              const transformer = transformations[req.appVersion] || transformations["1.0.0"];
-              data = transformer(data);
-            }
-
-            // Reset the send function to its original behavior
-            res.send = originalSend;
-
-            // Call the original send function with the transformed (or original) data
-            originalSend.call(res, data);
-          };
-
-          next();
-        });
-      }
-
       actions.push((req, res, next) => {
         if (_.get(req, "query.token")) {
           _.set(req, "headers.authorization", `Bearer ${_.trim(req.query.token)}`);

src/common/transformations.js

@@ -20,7 +20,6 @@ module.exports = {
         constants.UserRoles.User,
       ],
       scopes: [READ, ALL],
-      versioned: true,
     },
     post: {
       controller: "ChallengeController",
@@ -52,7 +51,6 @@ module.exports = {
       controller: "ChallengeController",
       method: "getChallenge",
       scopes: [READ, ALL],
-      versioned: true,
     },
     // @deprecated
     put: {