make sure there are no previous phases if the timeline template has changed

ThomasKranitsas · ThomasKranitsas · commit 469b95fae468 · 2021-06-24T22:07:19.000+03:00
diff --git a/src/services/ChallengeService.js b/src/services/ChallengeService.js
@@ -1414,6 +1414,9 @@ async function update (currentUser, challengeId, data, isFull) {
     if (finalStatus !== constants.challengeStatuses.New && finalTimelineTemplateId !== challenge.timelineTemplateId) {
       throw new errors.BadRequestError(`Cannot change the timelineTemplateId for challenges with status: ${finalStatus}`)
     }
+  } else {
+    // make sure there are no previous phases if the timeline template has changed
+    challenge.phases = []
   }
 
   if (data.prizeSets) {

Original file line number	Diff line number	Diff line change
`@@ -1414,6 +1414,9 @@ async function update (currentUser, challengeId, data, isFull) {`
`1414`	`1414`	`if (finalStatus !== constants.challengeStatuses.New && finalTimelineTemplateId !== challenge.timelineTemplateId) {`
`1415`	`1415`	throw new errors.BadRequestError(`Cannot change the timelineTemplateId for challenges with status: ${finalStatus}`)
`1416`	`1416`	`}`
	`1417`	`+ } else {`
	`1418`	`+ // make sure there are no previous phases if the timeline template has changed`
	`1419`	`+ challenge.phases = []`
`1417`	`1420`	`}`
`1418`	`1421`
`1419`	`1422`	`if (data.prizeSets) {`