Validate Group Ids are valid or not

Author: sarojbehera1

src/common/helper.js

@@ -896,9 +896,29 @@ async function validateChallengeTerms(terms = []) {
 async function _filterChallengesByGroupsAccess(currentUser, challenges) {
   const res = [];
   const needToCheckForGroupAccess = !currentUser
-    ? true
-    : !currentUser.isMachine && !hasAdminRole(currentUser);
-  if (!needToCheckForGroupAccess) return challenges;
+  ? true
+  : !currentUser.isMachine && !hasAdminRole(currentUser);
+  if(!needToCheckForGroupAccess)
+  {
+    for (const challenge of challenges) {
+      if(challenge && challenge.groups && challenge.groups.length>0) {
+        const promises = [];
+        _.each(challenge.groups, (g) => {
+          promises.push(
+            (async () => {
+              const group = await getGroupById(g);
+              if ( !group || !group.status==='active') {
+                throw new errors.BadRequestError("The groups provided are invalid "+g);
+              }
+            })()
+          );
+        });
+        await Promise.all(promises);
+        res.push(challenge);
+      }
+    }
+    return res;
+  }
 
   let userGroups;