unset legacy.directProjectId as we do not allowe this to change

ThomasKranitsas · ThomasKranitsas · commit 28d164684d82 · 2023-03-25T11:37:06.000+02:00
diff --git a/src/services/ChallengeService.js b/src/services/ChallengeService.js
@@ -1517,9 +1517,7 @@ async function updateChallenge(currentUser, challengeId, data) {
 
   // Make sure the user cannot change the direct project ID
   if (data.legacy && data.legacy.directProjectId) {
-    const { directProjectId } = await projectHelper.getProject(projectId, currentUser);
-
-    _.set(challenge, "legacy.directProjectId", directProjectId);
+    _.unset(data, "legacy.directProjectId", directProjectId);
   }
 
   /* BEGIN self-service stuffs */

Original file line number	Diff line number	Diff line change
`@@ -1517,9 +1517,7 @@ async function updateChallenge(currentUser, challengeId, data) {`
`1517`	`1517`
`1518`	`1518`	`// Make sure the user cannot change the direct project ID`
`1519`	`1519`	`if (data.legacy && data.legacy.directProjectId) {`
`1520`		`- const { directProjectId } = await projectHelper.getProject(projectId, currentUser);`
`1521`		`-`
`1522`		`- _.set(challenge, "legacy.directProjectId", directProjectId);`
	`1520`	`+ _.unset(data, "legacy.directProjectId", directProjectId);`
`1523`	`1521`	`}`
`1524`	`1522`
`1525`	`1523`	`/* BEGIN self-service stuffs */`