From 50ff6bcdb6b95383934dcde6322093c19d86a673 Mon Sep 17 00:00:00 2001 From: Michael Baghel Date: Sat, 24 Jul 2021 04:21:51 +0400 Subject: [PATCH 1/2] Update utils.js --- src/routes/JobForm/utils.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/routes/JobForm/utils.js b/src/routes/JobForm/utils.js index 9f2876ec..2b4c0fe5 100644 --- a/src/routes/JobForm/utils.js +++ b/src/routes/JobForm/utils.js @@ -27,7 +27,7 @@ const EDIT_JOB_ROWS = [ ]; const validateDuration = (x, y, {duration}) => { - if (duration === undefined) return undefined; + if (!duration) return undefined; const converted = Number(duration); if (isNaN(converted) || converted < MIN_DURATION) { From 6780ad7af7cfc7e5c40d227771b2fed37dc13dd2 Mon Sep 17 00:00:00 2001 From: Michael Baghel Date: Sat, 24 Jul 2021 04:54:29 +0400 Subject: [PATCH 2/2] Update index.jsx --- src/routes/PositionDetails/index.jsx | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/routes/PositionDetails/index.jsx b/src/routes/PositionDetails/index.jsx index 584727aa..361f1dc4 100644 --- a/src/routes/PositionDetails/index.jsx +++ b/src/routes/PositionDetails/index.jsx @@ -5,6 +5,7 @@ */ import React, { useCallback, useEffect, useState } from "react"; import PT from "prop-types"; +import { navigate } from "@reach/router"; import Page from "components/Page"; import LoadingIndicator from "components/LoadingIndicator"; import PageHeader from "components/PageHeader"; @@ -39,9 +40,9 @@ const PositionDetails = ({ teamId, positionId, candidateStatus }) => { const onCandidateStatusChange = useCallback( (statusFilter) => { - setCandidateStatusFilterKey(statusFilter.key); + navigate(`/taas/myteams/${teamId}/positions/${positionId}/candidates/${statusFilter.urlParam}`); }, - [setCandidateStatusFilterKey] + [teamId, positionId] ); // if there are some candidates to review, then show "To Review" tab by default