merge

Author: Ghost141

.gitignore

@@ -4,3 +4,6 @@ pids
 deploy/prod.sh
 node_modules
 test/tmp/submissions/*.zip
+test/tmp/design_submissions/*.zip
+test/tmp/design_tmp_submissions/*.zip
+

actions/challengeRegistration.js

@@ -3,20 +3,32 @@
  *
  * The APIs to register a challenge (studio category or software category) for the current logged-in user.
  *
- * @version 1.1
- * @author ecnu_haozi, xjtufreeman
+ * @version 1.3
+ * @author ecnu_haozi, xjtufreeman, bugbuka
  *
  * changes in 1.1:
  * Combine Challenge Registration API(BUGR-11058)
+ *
+ * changes in 1.2:
+ * Integrate the forums operation(Module Assembly - Integrating Forums Wrapper with Challenge Registration API)
+ *
+ * changes in 1.3:
+ * move common function getForumWrapper, aduitResourceAddition to challengeHelper.js
  */
 "use strict";
 
 var async = require('async');
 var _ = require('underscore');
 var moment = require('moment');
+var ForumWrapper = require("forum-connector").ForumWrapper;
 var NotFoundError = require('../errors/NotFoundError');
 var ForbiddenError = require('../errors/ForbiddenError');
 
+/**
+ * The forum wrapper instance
+ */
+var forumWrapper = null;
+
 //constants
 var DESIGN_PROJECT_TYPE = 1,
     DEVELOPMENT_PROJECT_TYPE = 2,
@@ -125,7 +137,7 @@ var persistResource = function (api, resourceId, userId, challengeId, dbConnecti
         modifyUser: '"' + userId + '"'
     },
         dbConnectionMap,
-        function (err, result) {
+        function (err) {
             if (err) {
                 next(err);
             } else {
@@ -134,28 +146,6 @@ var persistResource = function (api, resourceId, userId, challengeId, dbConnecti
         });
 };
 
-/**
- * Audit the challenge registration on table 'tcs_catalog.project_user_audit'.
- *
- * @param {Object} api The api object that is used to access the infrastructure.
- * @param {Number} resourceId The resource id.
- * @param {Number} userId The current logged-in user's id.
- * @param {Number} challengeId The id of the challenge to register.
- * @param {Object} dbConnectionMap The database connection map for the current request.
- * @param {Function<err, data>} next The callback to be called after this function is done.
- */
-var aduitResourceAddition = function (api, userId, challengeId, dbConnectionMap, next) {
-    api.dataAccess.executeQuery("audit_challenge_registration", {
-        projectId: challengeId,
-        resourceUserId: userId,
-        resourceRoleId: SUBMITTER_RESOURCE_ROLE_ID,
-        auditActionTypeId: PROJECT_USER_AUDIT_CREATE_TYPE,
-        actionUserId: userId
-    },
-        dbConnectionMap,
-        next);
-};
-
 /**
  * Check if the rating suit for software category contests. 
  * The code logic is duplicated from server-side java code.
@@ -212,8 +202,9 @@ var prepareProjectResult = function (api, rating, userId, challengeId, phaseId,
  *
  * @param {Object} api The api object that is used to access the infrastructure.
  * @param {Number} resourceId The resource id.
- * @param {Number} userId The current logged-in user's id.
- * @param {Number} challengeId The id of the challenge to register.
+ * @param {Number} propertyId The property id.
+ * @param {String} propertyValue The property value.
+ * @param {Number} userId The user id.
  * @param {Object} dbConnectionMap The database connection map for the current request.
  * @param {Function<err, data>} next The callback to be called after this function is done..
  */
@@ -254,7 +245,7 @@ var projectTrack = function (api, userId, challengeId, componentInfo, dbConnecti
         function (resourceId, callback) {
             async.parallel([
                 function (cb) {
-                    aduitResourceAddition(api, userId, challengeId, dbConnectionMap, cb);
+                    api.challengeHelper.aduitResourceAddition(api, userId, challengeId, SUBMITTER_RESOURCE_ROLE_ID, PROJECT_USER_AUDIT_CREATE_TYPE, dbConnectionMap, cb);
                 },
                 function (cb) {
                     prepareProjectResult(
@@ -346,12 +337,13 @@ var projectTrack = function (api, userId, challengeId, componentInfo, dbConnecti
  * Send email to notify the user registration succeeded.
  *
  * @param {Object} api The api object that is used to access the infrastructure.
- * @param {Number} userId The current logged-in user's id.
  * @param {Object} componentInfo The component info object generated from method <code>registerComponentInquiry</code>.
+ * @param {Number} userId The current logged-in user's id.
+ * @param {Number} activeForumCategoryId The active forum category id.
  * @param {Object} dbConnectionMap The database connection map for the current request.
  * @param {Function<err, data>} next The callback to be called after this function is done.
  */
-var sendNotificationEmail = function (api, componentInfo, userId, dbConnectionMap, next) {
+var sendNotificationEmail = function (api, componentInfo, userId, activeForumCategoryId, dbConnectionMap, next) {
     async.waterfall([
         function (cb) {
             api.dataAccess.executeQuery("get_user_email_and_handle", {
@@ -363,7 +355,7 @@ var sendNotificationEmail = function (api, componentInfo, userId, dbConnectionMa
                 cb(new NotFoundError("user's email and handle not found"));
                 return;
             }
-            var user, projectName, documentationDetails, submitURL, activeForumCategoryId, forumURL, umlToolInfo;
+            var user, projectName, documentationDetails, submitURL, forumURL, umlToolInfo;
 
             user = result[0];
             projectName = componentInfo.project_name + api.helper.getPhaseName(componentInfo.phase_id) + ' Contest';
@@ -378,7 +370,7 @@ var sendNotificationEmail = function (api, componentInfo, userId, dbConnectionMa
 
             if (componentInfo.phase_id === 112 || componentInfo.phase_id === 113) {
                 umlToolInfo = "You can read more about our UML tool and download it at\n" +
-                        "http://www.topcoder.com/tc?module=Static&d1=dev&d2=umltool&d3=description\n\n";
+                    "http://www.topcoder.com/tc?module=Static&d1=dev&d2=umltool&d3=description\n\n";
             }
 
             //NOTE : forumURL is out of scope, here use a mock value instead. See http://apps.topcoder.com/forums/?module=Thread&threadID=811696&start=0
@@ -403,6 +395,80 @@ var sendNotificationEmail = function (api, componentInfo, userId, dbConnectionMa
     ], next);
 };
 
+/*
+ * Get the active forum category id of the specified challenge.
+ *
+ * @param {Object} api The api object that is used to access the infrastructure.
+ * @param {Object} componentInfo The component info object generated from method <code>registerComponentInquiry</code>.
+ * @param {Number} challengeId The challenge id.
+ * @param {Object} dbConnectionMap The database connection map for the current request.
+ * @param {Function<err, data>} next The callback to be called after this function is done.
+ */
+var getActiveForumCategoryId = function (api, componentInfo, challengeId, dbConnectionMap, next) {
+    async.waterfall([
+        function (cb) {
+            if (componentInfo.component_id === null) {
+                api.log('Could not find component for challenge ' + challengeId, 'error');
+                next(new Error('Could not find component for challenge ' + challengeId));
+                return;
+            }
+            api.dataAccess.executeQuery("get_active_forum_category", {componentId: componentInfo.component_id}, dbConnectionMap, cb);
+        },
+        function (result, cb) {
+            if (result.length === 0) {
+                api.log('Could not find forum for challenge ' + challengeId, 'debug');
+                cb(null, null);
+                return;
+            }
+
+            cb(null, result[0].jive_category_id);
+        }
+    ], next);
+};
+
+/*
+ * Grant user forum access
+ *
+ * @param {Object} api The api object that is used to access the infrastructure.
+ * @param {Number} userId The current logged-in user's id.
+ * @param {Number} challengeId The challenge id.
+ * @param {Function<err, data>} next The callback to be called after this function is done.
+ */
+var grantForumAccess = function (api, userId, activeForumCategoryId, next) {
+
+    if (api.config.general.grantForumAccess !== true) {
+        next();
+        return;
+    }
+
+    if (activeForumCategoryId === null) {
+        api.log('Could not find forum category ' + activeForumCategoryId, 'error');
+        next(new Error('Could not find forum category ' + activeForumCategoryId));
+        return;
+    }
+
+    api.log('start to grant user ' + userId + ' forum category ' +  activeForumCategoryId + ' access.');
+    async.waterfall([
+        function (cb) {
+            api.challengeHelper.getForumWrapper(api, cb);
+        }, function (forumWrapper, cb) {
+            forumWrapper.assignRole(userId, "Software_Users_" + activeForumCategoryId, function (err) {
+                if (err) {
+                    api.log('Failed to grant user ' + userId + ' forum category ' +  activeForumCategoryId + ' access:' + err + " " + (err.stack || ''), 'error');
+                    cb(new Error('Failed to grant user ' + userId + ' forum category ' +  activeForumCategoryId + ' access'));
+                }
+                cb();
+            });
+        }
+    ], function (err) {
+        if (err) {
+            next(err);
+            return;
+        }
+        next();
+    });
+};
+
 /**
  * Register a development (software) challenge for the current logged-in user.
  *
@@ -430,10 +496,24 @@ var registerSoftwareChallenge = function (api, userId, challengeId, dbConnection
                 cb(err);
             });
         },
+
         function (cb) {
-            //Send notification mail
-            sendNotificationEmail(api, componentInfo, userId, dbConnectionMap, cb);
+            getActiveForumCategoryId(api, componentInfo, challengeId, dbConnectionMap, cb);
+        },
+
+        function (activeForumCategoryId, cb) {
+            async.waterfall([
+                function (cbx) {
+                    // Grant forum access
+                    grantForumAccess(api, userId, activeForumCategoryId, cbx);
+                },
+                function (cbx) {
+                    // Send notification mail
+                    sendNotificationEmail(api, componentInfo, userId, activeForumCategoryId, dbConnectionMap, cbx);
+                }
+            ], cb);
         }
+
     ], next);
 };
 
@@ -484,7 +564,7 @@ var persistStudioChallengeResouce = function (api, userId, challengeId, dbConnec
                 },
                 function (cb) {
                     //Registration time
-                    persistResourceInfo(api, resourceId, 6, moment().format("MM.dd.yyyy hh:mm aa"), userId, dbConnectionMap, cb);
+                    persistResourceInfo(api, resourceId, 6, moment().format("MM.DD.YYYY hh:mm A"), userId, dbConnectionMap, cb);
                 },
                 function (cb) {
                     //payments.
@@ -528,6 +608,8 @@ var timelineNotification = function (api, userId, challengeId, dbConnectionMap,
                 },
                     dbConnectionMap,
                     cb);
+            } else {
+                cb(null);
             }
         }
     ], next);
@@ -566,23 +648,23 @@ var registerSoftwareChallengeAction = function (api, connection, next) {
     if (connection.dbConnectionMap) {
         api.log("Execute registerSoftwareChallengeAction#run", 'debug');
 
-        var challengeId = Number(connection.params.challengeId);
-        var sqlParams = {
-            challengeId: challengeId,
-            user_id: connection.caller.userId
-        };
-        var execQuery = function (name) {
-            return function (cbx) {
-                api.dataAccess.executeQuery(name, sqlParams, connection.dbConnectionMap, cbx);
+        var challengeId = Number(connection.params.challengeId),
+            sqlParams = {
+                challengeId: challengeId,
+                user_id: connection.caller.userId
+            },
+            execQuery = function (name) {
+                return function (cbx) {
+                    api.dataAccess.executeQuery(name, sqlParams, connection.dbConnectionMap, cbx);
+                };
             };
-        };
         async.waterfall([
-            function(cb) {
+            function (cb) {
                 async.parallel({
                     isCopilotPosting: execQuery('check_challenge_is_copilot_posting'),
                     isCopilot: execQuery('check_is_copilot')
                 }, cb);
-            }, function(res, cb) {
+            }, function (res, cb) {
                 if (res.isCopilotPosting.length > 0 && res.isCopilotPosting[0].challenge_is_copilot) {
                     if (res.isCopilot.length === 0 || !res.isCopilot[0].user_is_copilot) {
                         cb(new ForbiddenError('You should be a copilot before register a copilot posting.'));