Skip to content
This repository was archived by the owner on Jan 23, 2025. It is now read-only.

Commit 2217fe7

Browse files
author
fireice.topcoder
committed
Merge branch 'member_registration_api_update_2'
2 parents 0a6679a + 8cc9781 commit 2217fe7

File tree

5 files changed

+26
-10
lines changed

5 files changed

+26
-10
lines changed

actions/memberRegistration.js

Lines changed: 18 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -129,8 +129,7 @@ function codeRandom(coderId) {
129129
} while (oldseed.toNumber() === nextseed.toNumber());
130130
cr.seed = nextseed;
131131
return nextseed.shiftRight(16).toNumber();
132-
}
133-
132+
};
134133
return cr;
135134
}
136135

@@ -190,7 +189,10 @@ function getCode(coderId) {
190189
* @param {Function} next - The callback function
191190
*/
192191
var registerUser = function (user, api, dbConnectionMap, next) {
193-
var activationCode;
192+
var activationCode,
193+
utm_source = user.utm_source || '',
194+
utm_medium = user.utm_medium || '',
195+
utm_campaign = user.utm_campaign || '';
194196
// Get the next user id
195197
api.idGenerator.getNextID("USER_SEQ", dbConnectionMap, function (err, result) {
196198
if (err) {
@@ -205,7 +207,18 @@ var registerUser = function (user, api, dbConnectionMap, next) {
205207
var regSource = user.regSource !== null && user.regSource !== undefined ? user.regSource : 'api';
206208
// use user id as activation code for now
207209
activationCode = getCode(user.id);
208-
api.dataAccess.executeQuery("insert_user", {userId : user.id, firstName : user.firstName, lastName : user.lastName, handle : user.handle, status : status, activationCode : activationCode, regSource : regSource}, dbConnectionMap, function (err, result) {
210+
api.dataAccess.executeQuery("insert_user", {
211+
userId : user.id,
212+
firstName : user.firstName,
213+
lastName : user.lastName,
214+
handle : user.handle,
215+
status : status,
216+
activationCode : activationCode,
217+
regSource : regSource,
218+
utm_source : utm_source,
219+
utm_medium : utm_medium,
220+
utm_campaign : utm_campaign},
221+
dbConnectionMap, function (err, result) {
209222
callback(err, result);
210223
});
211224
},
@@ -955,7 +968,7 @@ exports.memberRegister = {
955968
description: "Register a new member",
956969
inputs: {
957970
required: ["firstName", "lastName", "handle", "country", "email"],
958-
optional: ["password", "socialProviderId", "socialUserName", "socialEmail", "socialEmailVerified", "regSource", "socialUserId"]
971+
optional: ["password", "socialProviderId", "socialUserName", "socialEmail", "socialEmailVerified", "regSource", "socialUserId", "utm_source", "utm_medium", "utm_campaign"]
959972
},
960973
blockedConnectionTypes : [],
961974
outputExample : {},

queries/insert_user

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,2 +1,2 @@
1-
INSERT INTO user(user_id, first_name, last_name, handle, status, activation_code, reg_source)
2-
VALUES (@userId@, '@firstName@', '@lastName@', '@handle@', '@status@', '@activationCode@', '@regSource@')
1+
INSERT INTO user(user_id, first_name, last_name, handle, status, activation_code, reg_source, utm_source, utm_medium, utm_campaign)
2+
VALUES (@userId@, '@firstName@', '@lastName@', '@handle@', '@status@', '@activationCode@', '@regSource@', '@utm_source@', '@utm_medium@', '@utm_campaign@')
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
user_id,first_name,last_name,handle,status,activation_code,reg_source from user where handle = 'testHandleFoo'
1+
user_id,first_name,last_name,handle,status,activation_code,reg_source,utm_source,utm_medium,utm_campaign from user where handle = 'testHandleFoo'

test/test.register_member.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -253,7 +253,7 @@ describe('Test Register Member API', function () {
253253
it('should register successfully', function (done) {
254254
supertest(API_ENDPOINT)
255255
.post('/v2/users').set('Accept', 'application/json')
256-
.send({ firstName: 'foo', lastName: 'bar', handle: 'testHandleFoo', email: 'testHandleFoo@foobar.com', password: '123456', country: 'Japan', socialProviderId: 1, socialUserName: "foobar", socialEmail: "foobar@foobar.com", socialEmailVerified: 't', regSource: "source1", "socialUserId": 2 })
256+
.send({ firstName: 'foo', lastName: 'bar', handle: 'testHandleFoo', email: 'testHandleFoo@foobar.com', password: '123456', country: 'Japan', socialProviderId: 1, socialUserName: "foobar", socialEmail: "foobar@foobar.com", socialEmailVerified: 't', regSource: "source1", "socialUserId": 2, utm_source: "some source", utm_medium: "some medium", utm_campaign: "some campaign"})
257257
.expect('Content-Type', /json/)
258258
.expect(200)
259259
.end(function (err, result) {

test/test_files/exptected_member_register_validate_user.txt

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,5 +3,8 @@
33
"first_name": "foo",
44
"handle": "testHandleFoo",
55
"status": "U",
6-
"last_name": "bar"
6+
"last_name": "bar",
7+
"utm_source": "some source",
8+
"utm_medium": "some medium",
9+
"utm_campaign": "some campaign"
710
}

0 commit comments

Comments
 (0)