Merge branch 'master' into develop

Author: ThomasKranitsas

src/services/paymentService.js

@@ -85,7 +85,8 @@ async function createPayment(payment) {
       const paymentDetailId = await paymentDetailIdGen.getNextId()
       const paymentId = await paymentIdGen.getNextId()
       const insertDetail = await prepare(connection, INSERT_PAYMENT_DETAIL)
-      await insertDetail.executeAsync([paymentDetailId, payment.amount, payment.amount, payment.statusId, payment.modificationRationaleId, payment.desc, payment.typeId, payment.methodId, payment.projectId, payment.charityInd, payment.amount, payment.installmentNumber, payment.createUser, payment.v5ChallengeId])
+      await insertDetail.executeAsync([paymentDetailId, payment.amount, payment.amount, payment.statusId, payment.modificationRationaleId, payment.desc, payment.typeId, payment.methodId, payment.projectId, payment.charityInd, payment.amount, payment.installmentNumber, payment.createUser, payment.
+                                      ])
       const insertPayment = await prepare(connection, INSERT_PAYMENT)
       await insertPayment.executeAsync([paymentId, payment.memberId, paymentDetailId])
       const insertDetailXref = await prepare(connection, INSERT_PAYMENT_DETAIL_XREF)

src/services/processorService.js

@@ -19,7 +19,7 @@ async function processUpdate(message) {
   const legacyId = _.get(message, 'payload.legacyId', null)
   const v5ChallengeId = _.get(message, 'payload.id', null)
 
-  if (!v5ChallengeId) {
+  if (!v5ChallengeId || v5ChallengeId === '') {
     logger.error('Payload of challenge does not contain a v5 Challenge UUID')
     return false
   }