Config fixes

Author: James Cori

config/default.js

@@ -40,12 +40,12 @@ module.exports = {
   // Topcoder APIs
   TC_API: process.env.TC_API || 'https://api.topcoder-dev.com/v5',
 
-  PAYMENT_STATUS_ID: process.env.PAYMENT_STATUS_ID || 56,
+  PAYMENT_STATUS_ID: process.env.PAYMENT_STATUS_ID || 55, // on hold
   MODIFICATION_RATIONALE_ID: process.env.MODIFICATION_RATIONALE_ID || 1,
   WINNER_PAYMENT_TYPE_ID: process.env.WINNER_PAYMENT_TYPE_ID || 72,
   COPILOT_PAYMENT_TYPE_ID: process.env.COPILOT_PAYMENT_TYPE_ID || 74,
 
-  V5_PAYMENT_DETAIL_STATUS_ID: process.env.V5_PAYMENT_DETAIL_STATUS_ID || 500,
+  V5_PAYMENT_DETAIL_STATUS_REASON_ID: process.env.V5_PAYMENT_DETAIL_STATUS_REASON_ID || 500,
 
   PAYMENT_METHOD_ID: process.env.PAYMENT_METHOD_ID || 1,
   CHARITY_IND: process.env.CHARITY_IND || 0,

src/services/paymentService.js

@@ -4,6 +4,7 @@
  */
 const logger = require('../common/logger')
 const helper = require('../common/helper')
+const config = require('config');
 const IDGenerator = require('../common/idGenerator')
 
 // the paymentDetailId's generator
@@ -49,7 +50,7 @@ async function createPayment (payment) {
     const insertDetailXref = await prepare(connection, INSERT_PAYMENT_DETAIL_XREF)
     await insertDetailXref.executeAsync([paymentId, paymentDetailId])
     const insertStatusXref = await prepare(connection, INSERT_PAYMENT_STATUS_REASON_XREF)
-    await insertStatusXref.executeAsync([paymentDetailId, V5_PAYMENT_DETAIL_STATUS_ID])
+    await insertStatusXref.executeAsync([paymentDetailId, config.V5_PAYMENT_DETAIL_STATUS_REASON_ID])
     logger.info(`Payment ${paymentId} with detail ${paymentDetailId} has been inserted`)
     await connection.commitTransactionAsync()
   } catch (e) {