From c14f5851b5cfa898808c974c1425d917866413fb Mon Sep 17 00:00:00 2001 From: eisbilir Date: Sun, 26 Jun 2022 09:58:12 +0300 Subject: [PATCH 1/4] fix reviewer number query --- src/services/selfServiceReviewerService.js | 13 ++++++------- 1 file changed, 6 insertions(+), 7 deletions(-) diff --git a/src/services/selfServiceReviewerService.js b/src/services/selfServiceReviewerService.js index e46cd05..05367dd 100644 --- a/src/services/selfServiceReviewerService.js +++ b/src/services/selfServiceReviewerService.js @@ -6,10 +6,10 @@ const util = require('util') const logger = require('../common/logger') const helper = require('../common/helper') -const QUERY_GET_ENTRY = 'SELECT parameter FROM phase_criteria WHERE project_phase_id = %d' +const QUERY_GET_ENTRY = 'SELECT parameter FROM phase_criteria WHERE project_phase_id = %d AND phase_criteria_type_id = 6' const QUERY_CREATE = 'INSERT INTO phase_criteria (project_phase_id, phase_criteria_type_id, parameter, create_user, create_date, modify_user, modify_date) VALUES (?, 6, ?, ?, CURRENT, ?, CURRENT)' -const QUERY_UPDATE = 'UPDATE phase_criteria SET parameter = ?, modify_user = ?, modify_date = CURRENT WHERE project_phase_id = ?' -const QUERY_DELETE = 'DELETE FROM phase_criteria WHERE project_phase_id = ?' +const QUERY_UPDATE = 'UPDATE phase_criteria SET parameter = ?, modify_user = ?, modify_date = CURRENT WHERE project_phase_id = ? AND phase_criteria_type_id = 6' +const QUERY_DELETE = 'DELETE FROM phase_criteria WHERE project_phase_id = ? AND phase_criteria_type_id = 6' /** * Prepare Informix statement @@ -43,10 +43,9 @@ async function getEntry (phaseId) { } /** - * Enable timeline notifications + * Merge number of reviewers * @param {Number} phaseId the legacy challenge ID - * @param {Number} typeId the type ID - * @param {Any} value the value + * @param {Number=} value the value * @param {String} createdBy the created by */ async function createOrSetNumberOfReviewers (phaseId, value, createdBy) { @@ -67,7 +66,7 @@ async function createOrSetNumberOfReviewers (phaseId, value, createdBy) { } } else { const query = await prepare(connection, QUERY_CREATE) - logger.info(`Will delete with values: ${phaseId}, ${value}, ${createdBy}, ${createdBy}`) + logger.info(`Will create with values: ${phaseId}, ${value}, ${createdBy}, ${createdBy}`) result = await query.executeAsync([phaseId, value, createdBy, createdBy]) } await connection.commitTransactionAsync() From 991a756ad62fbbf671c007e6c46cbbcf0ec6fe38 Mon Sep 17 00:00:00 2001 From: LieutenantRoger Date: Sat, 2 Jul 2022 16:06:04 +0800 Subject: [PATCH 2/4] encode tags --- src/services/ProcessorService.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/services/ProcessorService.js b/src/services/ProcessorService.js index fec370f..6045514 100644 --- a/src/services/ProcessorService.js +++ b/src/services/ProcessorService.js @@ -342,7 +342,7 @@ async function getLegacyTrackInformation (trackId, typeId, tags, m2mToken) { `typeId=${typeId}` ] _.each((tags || []), (tag) => { - query.push(`tags[]=${tag}`) + query.push(`tags[]=${encodeURIComponent(tag)}`) }) try { const res = await helper.getRequest(`${config.V5_CHALLENGE_MIGRATION_API_URL}/convert-to-v4?${query.join('&')}`, m2mToken) From 0266cbbfd8d76d50b0d7e936a4a7c0b0c42a9923 Mon Sep 17 00:00:00 2001 From: LieutenantRoger Date: Sat, 2 Jul 2022 16:06:55 +0800 Subject: [PATCH 3/4] deploying encode tag fix --- .circleci/config.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.circleci/config.yml b/.circleci/config.yml index 3a78bbe..13ff569 100644 --- a/.circleci/config.yml +++ b/.circleci/config.yml @@ -70,6 +70,7 @@ workflows: branches: only: - develop + - PLAT_1128 # Production builds are exectuted only on tagged commits to the # master branch. From ea41a33e8c37512a37e0acc1240e4854fc17cc50 Mon Sep 17 00:00:00 2001 From: LieutenantRoger Date: Tue, 5 Jul 2022 16:04:46 +0800 Subject: [PATCH 4/4] recover ci --- .circleci/config.yml | 1 - 1 file changed, 1 deletion(-) diff --git a/.circleci/config.yml b/.circleci/config.yml index 13ff569..3a78bbe 100644 --- a/.circleci/config.yml +++ b/.circleci/config.yml @@ -70,7 +70,6 @@ workflows: branches: only: - develop - - PLAT_1128 # Production builds are exectuted only on tagged commits to the # master branch.