From da8aed9fb1c0ddcf4d40e77f2706cb9427b7f1ee Mon Sep 17 00:00:00 2001 From: Thomas Kranitsas Date: Tue, 2 Aug 2022 02:19:24 +0300 Subject: [PATCH 1/5] temp hotfix to update the phase status of a live challenge --- src/services/ProcessorService.js | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/services/ProcessorService.js b/src/services/ProcessorService.js index 6045514..81e99a3 100644 --- a/src/services/ProcessorService.js +++ b/src/services/ProcessorService.js @@ -89,9 +89,9 @@ async function syncChallengePhases (legacyId, v5Phases, createdBy, isSelfService // || // (v5Equivalent.isOpen && _.toInteger(phase.phase_status_id) === constants.PhaseStatusTypes.Closed) || // (!v5Equivalent.isOpen && _.toInteger(phase.phase_status_id) === constants.PhaseStatusTypes.Open)) { - // const newStatus = v5Equivalent.isOpen - // ? constants.PhaseStatusTypes.Open - // : (new Date().getTime() <= new Date(v5Equivalent.scheduledEndDate).getTime() ? constants.PhaseStatusTypes.Scheduled : constants.PhaseStatusTypes.Closed) + const newStatus = v5Equivalent.isOpen + ? constants.PhaseStatusTypes.Open + : (new Date().getTime() <= new Date(v5Equivalent.scheduledEndDate).getTime() ? constants.PhaseStatusTypes.Scheduled : constants.PhaseStatusTypes.Closed) // update phase logger.debug(`Will update phase ${phaseName}/${v5Equivalent.name} from ${phase.duration} to duration ${v5Equivalent.duration * 1000} milli`) await timelineService.updatePhase( @@ -100,7 +100,7 @@ async function syncChallengePhases (legacyId, v5Phases, createdBy, isSelfService v5Equivalent.scheduledStartDate, v5Equivalent.scheduledEndDate, v5Equivalent.duration * 1000, - phase.phase_status_id + newStatus // phase.phase_status_id ) // newStatus) // } else { From 68ab0301c1e3071c4d231eb9624c3a87305cd826 Mon Sep 17 00:00:00 2001 From: Thomas Kranitsas Date: Tue, 2 Aug 2022 02:20:21 +0300 Subject: [PATCH 2/5] Revert "temp hotfix to update the phase status of a live challenge" This reverts commit da8aed9fb1c0ddcf4d40e77f2706cb9427b7f1ee. --- src/services/ProcessorService.js | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/services/ProcessorService.js b/src/services/ProcessorService.js index 81e99a3..6045514 100644 --- a/src/services/ProcessorService.js +++ b/src/services/ProcessorService.js @@ -89,9 +89,9 @@ async function syncChallengePhases (legacyId, v5Phases, createdBy, isSelfService // || // (v5Equivalent.isOpen && _.toInteger(phase.phase_status_id) === constants.PhaseStatusTypes.Closed) || // (!v5Equivalent.isOpen && _.toInteger(phase.phase_status_id) === constants.PhaseStatusTypes.Open)) { - const newStatus = v5Equivalent.isOpen - ? constants.PhaseStatusTypes.Open - : (new Date().getTime() <= new Date(v5Equivalent.scheduledEndDate).getTime() ? constants.PhaseStatusTypes.Scheduled : constants.PhaseStatusTypes.Closed) + // const newStatus = v5Equivalent.isOpen + // ? constants.PhaseStatusTypes.Open + // : (new Date().getTime() <= new Date(v5Equivalent.scheduledEndDate).getTime() ? constants.PhaseStatusTypes.Scheduled : constants.PhaseStatusTypes.Closed) // update phase logger.debug(`Will update phase ${phaseName}/${v5Equivalent.name} from ${phase.duration} to duration ${v5Equivalent.duration * 1000} milli`) await timelineService.updatePhase( @@ -100,7 +100,7 @@ async function syncChallengePhases (legacyId, v5Phases, createdBy, isSelfService v5Equivalent.scheduledStartDate, v5Equivalent.scheduledEndDate, v5Equivalent.duration * 1000, - newStatus // phase.phase_status_id + phase.phase_status_id ) // newStatus) // } else { From 344213dd3cd10293e5119a8b357fef9ecf03c633 Mon Sep 17 00:00:00 2001 From: Thomas Kranitsas Date: Mon, 19 Sep 2022 14:06:40 +0300 Subject: [PATCH 3/5] follow v5 or time for phase.phase_status_id in legacy --- src/services/ProcessorService.js | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/services/ProcessorService.js b/src/services/ProcessorService.js index 6045514..1146ada 100644 --- a/src/services/ProcessorService.js +++ b/src/services/ProcessorService.js @@ -94,13 +94,16 @@ async function syncChallengePhases (legacyId, v5Phases, createdBy, isSelfService // : (new Date().getTime() <= new Date(v5Equivalent.scheduledEndDate).getTime() ? constants.PhaseStatusTypes.Scheduled : constants.PhaseStatusTypes.Closed) // update phase logger.debug(`Will update phase ${phaseName}/${v5Equivalent.name} from ${phase.duration} to duration ${v5Equivalent.duration * 1000} milli`) + const newStatus = v5Equivalent.isOpen + ? constants.PhaseStatusTypes.Open + : (new Date().getTime() <= new Date(v5Equivalent.scheduledEndDate).getTime() ? constants.PhaseStatusTypes.Scheduled : constants.PhaseStatusTypes.Closed) await timelineService.updatePhase( phase.project_phase_id, legacyId, v5Equivalent.scheduledStartDate, v5Equivalent.scheduledEndDate, v5Equivalent.duration * 1000, - phase.phase_status_id + newStatus // phase.phase_status_id ) // newStatus) // } else { From c81026f3bbc8e5c11c32407dec87cef8bfed37bf Mon Sep 17 00:00:00 2001 From: eisbilir Date: Thu, 3 Nov 2022 19:35:50 +0300 Subject: [PATCH 4/5] hotfix PLAT-1711 --- src/services/ProcessorService.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/services/ProcessorService.js b/src/services/ProcessorService.js index 1146ada..42a5dd9 100644 --- a/src/services/ProcessorService.js +++ b/src/services/ProcessorService.js @@ -96,7 +96,7 @@ async function syncChallengePhases (legacyId, v5Phases, createdBy, isSelfService logger.debug(`Will update phase ${phaseName}/${v5Equivalent.name} from ${phase.duration} to duration ${v5Equivalent.duration * 1000} milli`) const newStatus = v5Equivalent.isOpen ? constants.PhaseStatusTypes.Open - : (new Date().getTime() <= new Date(v5Equivalent.scheduledEndDate).getTime() ? constants.PhaseStatusTypes.Scheduled : constants.PhaseStatusTypes.Closed) + : _.toInteger(phase.phase_status_id) === constants.PhaseStatusTypes.Scheduled ? constants.PhaseStatusTypes.Scheduled : constants.PhaseStatusTypes.Closed) await timelineService.updatePhase( phase.project_phase_id, legacyId, From 1ab16a90ff07bbf7407a9ea623696238934f15cd Mon Sep 17 00:00:00 2001 From: eisbilir Date: Mon, 7 Nov 2022 18:17:44 +0300 Subject: [PATCH 5/5] fix syntax --- src/services/ProcessorService.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/services/ProcessorService.js b/src/services/ProcessorService.js index 42a5dd9..19d2ddf 100644 --- a/src/services/ProcessorService.js +++ b/src/services/ProcessorService.js @@ -96,7 +96,7 @@ async function syncChallengePhases (legacyId, v5Phases, createdBy, isSelfService logger.debug(`Will update phase ${phaseName}/${v5Equivalent.name} from ${phase.duration} to duration ${v5Equivalent.duration * 1000} milli`) const newStatus = v5Equivalent.isOpen ? constants.PhaseStatusTypes.Open - : _.toInteger(phase.phase_status_id) === constants.PhaseStatusTypes.Scheduled ? constants.PhaseStatusTypes.Scheduled : constants.PhaseStatusTypes.Closed) + : (_.toInteger(phase.phase_status_id) === constants.PhaseStatusTypes.Scheduled ? constants.PhaseStatusTypes.Scheduled : constants.PhaseStatusTypes.Closed) await timelineService.updatePhase( phase.project_phase_id, legacyId,