From af80491356bfeeb89a9455fb505e462870457b82 Mon Sep 17 00:00:00 2001 From: Justin Gasper Date: Mon, 3 Oct 2022 14:17:10 +1100 Subject: [PATCH] Additional formality and logging --- src/services/ProcessorService.js | 8 ++++---- src/services/timelineService.js | 4 +++- 2 files changed, 7 insertions(+), 5 deletions(-) diff --git a/src/services/ProcessorService.js b/src/services/ProcessorService.js index fbe7831..257c713 100644 --- a/src/services/ProcessorService.js +++ b/src/services/ProcessorService.js @@ -58,10 +58,10 @@ async function recreatePhases (legacyId, v5Phases, createdBy) { if(phaseLegacyId==17){ logger.info(`Creating phase dependencies for checkpoint phases`) - registrationPhaseId = await timelineService.getProjectPhaseId(legacyId, 1) - checkpointSubmissionPhaseId = await timelineService.getProjectPhaseId(legacyId, 15) - checkpointScreeningPhaseId = await timelineService.getProjectPhaseId(legacyId, 16) - checkpointReviewPhaseId = await timelineService.getProjectPhaseId(legacyId, 17) + const registrationPhaseId = await timelineService.getProjectPhaseId(legacyId, 1) + const checkpointSubmissionPhaseId = await timelineService.getProjectPhaseId(legacyId, 15) + const checkpointScreeningPhaseId = await timelineService.getProjectPhaseId(legacyId, 16) + const checkpointReviewPhaseId = await timelineService.getProjectPhaseId(legacyId, 17) await timelineService.insertPhaseDependency(registrationPhaseId, checkpointSubmissionPhaseId, 1, createdBy) await timelineService.insertPhaseDependency(checkpointSubmissionPhaseId, checkpointScreeningPhaseId, 0, createdBy) diff --git a/src/services/timelineService.js b/src/services/timelineService.js index 99b3711..e2c6fd6 100644 --- a/src/services/timelineService.js +++ b/src/services/timelineService.js @@ -101,7 +101,9 @@ async function getProjectPhaseId(challengeLegacyId, phaseTypeId) { } finally { await connection.closeAsync() } - return _.get(result, '[0].project_phase_id', null) + const project_phase_id = _.get(result, '[0].project_phase_id', null) + logger.info(`Project phase ID: ${project_phase_id}`) + return project_phase_id } /** * Drop challenge phase