Skip to content
This repository was archived by the owner on Jan 23, 2025. It is now read-only.

Commit a1daead

Browse files
only dev self-service challenges have 1 reviewer
1 parent 284a77f commit a1daead

File tree

2 files changed

+6
-3
lines changed

2 files changed

+6
-3
lines changed

config/default.js

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -85,6 +85,8 @@ module.exports = {
8585
SYNC_V5_TERM_UUID: process.env.SYNC_V5_TERM_UUID || '317cd8f9-d66c-4f2a-8774-63c612d99cd4',
8686
SYNC_V5_WRITE_ENABLED: process.env.SYNC_V5_WRITE_ENABLED === 'true' || false,
8787

88+
DEV_TRACK_ID: '9b6fc876-f4d9-4ccb-9dfd-419247628825',
89+
8890
TIMEZONE: process.env.TIMEZONE || 'America/New_York',
8991

9092
IGNORED_ORIGINATORS: process.env.IGNORED_ORIGINATORS ? process.env.IGNORED_ORIGINATORS.split(',') : ['legacy-migration-script']

src/services/ProcessorService.js

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -73,7 +73,7 @@ async function recreatePhases (legacyId, v5Phases, createdBy) {
7373
* @param {Boolean} isSelfService is the challenge self-service
7474
* @param {String} createdBy the created by
7575
*/
76-
async function syncChallengePhases (legacyId, v5Phases, createdBy, isSelfService) {
76+
async function syncChallengePhases (legacyId, v5Phases, createdBy, isSelfService, numOfReviewers) {
7777
const phaseTypes = await timelineService.getPhaseTypes()
7878
const phasesFromIFx = await timelineService.getChallengePhases(legacyId)
7979
logger.debug(`Phases from v5: ${JSON.stringify(v5Phases)}`)
@@ -110,7 +110,7 @@ async function syncChallengePhases (legacyId, v5Phases, createdBy, isSelfService
110110
}
111111
if (isSelfService && phaseName === 'Review') {
112112
// make sure to set the required reviewers to 2
113-
await createOrSetNumberOfReviewers(_.toString(phase.project_phase_id), '2', _.toString(createdBy))
113+
await createOrSetNumberOfReviewers(_.toString(phase.project_phase_id), _.toString(numOfReviewers), _.toString(createdBy))
114114
}
115115
}
116116
// TODO: What about iterative reviews? There can be many for the same challenge.
@@ -709,7 +709,8 @@ async function processMessage (message) {
709709
}
710710

711711
if (!_.get(message.payload, 'task.isTask')) {
712-
await syncChallengePhases(legacyId, message.payload.phases, createdByUserId, _.get(message, 'payload.legacy.selfService'))
712+
const numOfReviewers = _.get(message, 'payload.legacy.selfService') && _.get(message, 'payload.trackId') === config.DEV_TRACK_ID ? 1 : 2
713+
await syncChallengePhases(legacyId, message.payload.phases, createdByUserId, _.get(message, 'payload.legacy.selfService'), numOfReviewers)
713714
} else {
714715
logger.info('Will skip syncing phases as the challenge is a task...')
715716
}

0 commit comments

Comments
 (0)