prevent incorrect challenge status changes

Author: ThomasKranitsas

src/constants.js

@@ -9,6 +9,15 @@ const prizeSetTypes = {
   CheckpointPrizes: 'checkpoint'
 }
 
+const challengeStatusOrders = {
+  draft: 0,
+  active: 1,
+  completed: 2,
+  deleted: 2,
+  cancelled: 2
+}
+
 module.exports = {
-  prizeSetTypes
+  prizeSetTypes,
+  challengeStatusOrders
 }

src/services/syncService.js

@@ -8,6 +8,7 @@ const challengeMigrationStatusService = require('../services/challengeMigrationS
 const migrationService = require('../services/migrationService')
 const challengeIfxService = require('../services/challengeInformixService')
 const { V4_TRACKS } = require('../util/conversionMappings')
+const { challengeStatusOrders } = require('../constants')
 
 async function syncLegacyId (legacyId, force) {
   // const legacyId = queuedChallenges.items[i].legacyId
@@ -47,6 +48,13 @@ async function processChallenge (legacyId, challengeListing, challengeDetails) {
   const v5ChallengeObjectFromV4 = await challengeService.buildV5Challenge(legacyId, challengeListing, challengeDetails)
   const [v5ChallengeFromAPI] = await challengeService.getChallengeFromV5API(legacyId)
 
+  const v4StatusOrder = challengeStatusOrders[_.toLower(v5ChallengeObjectFromV4.status)] || challengeStatusOrders.cancelled
+  const v5StatusOrder = challengeStatusOrders[_.toLower(v5ChallengeFromAPI.status)] || challengeStatusOrders.cancelled
+
+  if (v4StatusOrder < v5StatusOrder) {
+    v5ChallengeObjectFromV4.status = v5ChallengeFromAPI.status
+  }
+
   // logger.debug(`V5 Object Built from V4: ${JSON.stringify(v5ChallengeObjectFromV4)}`)
   // logger.debug(`V5 Object from API: ${JSON.stringify(v5ChallengeFromAPI)}`)