Fixing the migration and sync scripts to manage copilot payments

Author: rootelement

config/default.js

@@ -56,8 +56,8 @@ module.exports = {
 
   AMAZON: {
     // Uncomment for local deployment
-    // AWS_ACCESS_KEY_ID: process.env.AWS_FAKE_ID,
-    // AWS_SECRET_ACCESS_KEY: process.env.AWS_FAKE_KEY,
+    AWS_ACCESS_KEY_ID: process.env.AWS_FAKE_ID,
+    AWS_SECRET_ACCESS_KEY: process.env.AWS_FAKE_KEY,
     AWS_REGION: process.env.AWS_REGION || 'ap-northeast-1', // aws region
     IS_LOCAL_DB: process.env.IS_LOCAL_DB ? process.env.IS_LOCAL_DB === 'true' : false, // true or uninitialize if we use local instance
     DYNAMODB_URL: process.env.DYNAMODB_URL || 'http://localhost:8000', // just for local development

src/scripts/migrations/008-fix-copilot-payments.js

@@ -23,20 +23,43 @@ const migrationFunction = {
       logger.info(`Found ${challenges.length} challenges`)
       if (challenges.length > 0) {
         for (const challenge of challenges) {
-          const copilotPayment = _.get(_.find(_.get(challenge, 'prizeSets', []), p => p.type === config.COPILOT_PAYMENT_TYPE), 'prizes[0].value', null)
+          // for some reason they're still coming back with migration number 8.2
+          if (challenge.legacy && challenge.legacy.migration && _.toString(challenge.legacy.migration) === '8.2') {
+            logger.error(`Right Version ${challenge.legacyId} ${challenge.legacy.migration}`)
+            continue
+          }
           const legacyId = _.get(challenge, 'legacyId')
-          const existing = await challengeIfxService.getCopilotPaymentFromIfx(legacyId)
-          if (existing) {
-            if (!copilotPayment) {
-              await challengeIfxService.deleteCopilotPaymentFromIfx(legacyId)
-            } else if (_.toString(existing.value) !== _.toString(copilotPayment)) {
-              await challengeIfxService.updateCopilotPaymentInIfx(legacyId, copilotPayment, challenge.updatedBy)
+          if (!legacyId) {
+            logger.error(`No Legacy ID on challenge ${challenge.id}`)
+            continue
+          }
+          const legacyCopilotPayment = await challengeIfxService.getCopilotPaymentFromIfx(legacyId)
+          if (legacyCopilotPayment && legacyCopilotPayment.value > 0) {
+            let updatedChallenge
+            try {
+              [updatedChallenge] = await challengeService.getChallengeFromV5API(legacyId)
+            } catch (e) {
+              logger.debug('Unable to get challenge from v5... Skipping')
+              continue
+            }
+            if (updatedChallenge) {
+              // const copilotPayment = await challengeIfxService.getCopilotPaymentFromIfx(legacyId)
+              const prizeSet = { type: 'copilot', description: 'Copilot Payment' }
+              prizeSet.prizes = []
+              prizeSet.prizes.push({ value: legacyCopilotPayment.value, type: 'USD' })
+              updatedChallenge.prizeSets.push(prizeSet)
+              updatedChallenge.legacy.migration = 8.2
+              await challengeService.save(updatedChallenge)
             }
           } else {
-            await challengeIfxService.createCopilotPaymentInIfx(legacyId, copilotPayment, challenge.createdBy)
+            if (!challenge.legacy) {
+              challenge.legacy = { migration: 8.2 }
+            } else {
+              challenge.legacy.migration = 8.2
+            }
+            // logger.debug(`No Change - Saving Challenge ${challenge.legacy.migration}`)
+            await challengeService.save(challenge)
           }
-          challenge.legacy.migration = 8
-          challengeService.save(challenge)
         }
       } else {
         finish = true
@@ -55,22 +78,15 @@ async function getChallengesMissingData (page = 0, perPage = 10) {
     from: page * perPage,
     body: {
       query: {
-        bool: {
-          must: {
-            exists: {
-              field: 'prizeSets'
-            }
-          },
-          must_not: {
-            match_phrase: {
-              'legacy.migration': 8
-            }
+        range: {
+          'legacy.migration': {
+            lt: 8.2
           }
         }
       }
     }
   }
-  // logger.debug(`ES Query ${JSON.stringify(esQuery)}`)
+  logger.debug(`ES Query ${JSON.stringify(esQuery)}`)
   // Search with constructed query
   let docs
   try {

src/services/challengeInformixService.js

@@ -9,8 +9,10 @@ const { executeQueryAsync } = require('../util/informixWrapper')
  * @param {Number} legacyId the legacy ID
  */
 async function getCopilotPaymentFromIfx (legacyId) {
-  const sql = `SELECT limit 1 * FROM project_info WHERE project_info_type_id = 49 AND project_id = ${legacyId}`
-  return execQuery(sql)
+  const sql = `SELECT limit 1 * FROM project_info WHERE project_id = ${_.toInteger(legacyId)} AND project_info_type_id = 49`
+  const result = await execQuery(sql)
+  if (result && result[0]) return result[0]
+  return false
 }
 
 /**
@@ -32,7 +34,7 @@ async function createCopilotPaymentInIfx (legacyId, amount, createdBy) {
         modify_date
       )
     VALUES
-      (${legacyId}, 49, ${amount}, ${createdBy}, CURRENT, ${createdBy}, CURRENT)`
+      (${_.toInteger(legacyId)}, 49, ${amount}, ${createdBy}, CURRENT, ${createdBy}, CURRENT)`
   return execQuery(sql)
 }
 
@@ -43,7 +45,7 @@ async function createCopilotPaymentInIfx (legacyId, amount, createdBy) {
  * @param {String} updatedBy the update user handle
  */
 async function updateCopilotPaymentInIfx (legacyId, newValue, updatedBy) {
-  const sql = `UPDATE project_info SET value = ${newValue}, modify_user = ${updatedBy}, modify_date = CURRENT WHERE project_info_type_id = 49 AND project_id = ${legacyId}`
+  const sql = `UPDATE project_info SET value = ${newValue}, modify_user = ${updatedBy}, modify_date = CURRENT WHERE project_info_type_id = 49 AND project_id = ${_.toInteger(legacyId)}`
   return execQuery(sql)
 }
 
@@ -52,7 +54,7 @@ async function updateCopilotPaymentInIfx (legacyId, newValue, updatedBy) {
  * @param {Number} legacyId the legacy challenge id
  */
 async function deleteCopilotPaymentFromIfx (legacyId) {
-  const sql = `DELETE FROM project_info WHERE project_info_type_id = 49 AND project_id = ${legacyId}`
+  const sql = `DELETE FROM project_info WHERE project_info_type_id = 49 AND project_id = ${_.toInteger(legacyId)}`
   return execQuery(sql)
 }
 

src/services/challengeService.js

@@ -15,6 +15,7 @@ const resourceService = require('./resourceService')
 const resourceInformixService = require('./resourceInformixService')
 const translationService = require('./translationService')
 const { V4_TRACKS } = require('../util/conversionMappings')
+const { getCopilotPaymentFromIfx } = require('./challengeInformixService')
 
 let allV5Terms
 
@@ -34,9 +35,12 @@ const challengePropertiesToOmitFromDynamo = [
 
 async function save (challenge) {
   if (challenge.id) {
-    // logger.warn(`Updating Challenge ${JSON.stringify(challenge)}`)
+    // logger.debug(`Update Challenge ${challenge.id}`)
+    // return
     return updateChallenge(challenge)
   }
+  // logger.debug(`Create Challenge ${challenge.id}`)
+  // return
   return createChallenge(challenge)
 }
 /**
@@ -644,6 +648,14 @@ async function buildV5Challenge (legacyId, challengeListing, challengeDetails) {
     prizeSets.push(prizeSet)
   }
 
+  const copilotPayment = await getCopilotPaymentFromIfx(legacyId)
+  if (copilotPayment && copilotPayment.value > 0) {
+    const prizeSet = { type: 'copilot', description: 'Copilot Payment' }
+    prizeSet.prizes = []
+    prizeSet.prizes.push({ value: copilotPayment.value, type: 'USD' })
+    prizeSets.push(prizeSet)
+  }
+
   const tags = _.uniq(_.compact(_.concat(challengeListing.technologies, challengeListing.platforms, v5TrackProperties.tags)))
 
   const winners = _.map(challengeListing.winners, w => {