Fixing the created and createdBy being updated on update.

Author: rootelement

src/scripts/migrations/005-mmatches.js

@@ -30,6 +30,7 @@ const migrationFunction = {
 
     const challengeJson = { challenges: [] }
     const challengeIdsToDelete = []
+    const missingIds = []
 
     // logger.warn(await getMemberIdFromCache('TICKET_60375'))
     // return
@@ -40,12 +41,14 @@ const migrationFunction = {
       logger.info(`Found ${challenges.length} challenges`)
       if (challenges.length > 0) {
         for (const challenge of challenges) {
-          logger.debug(`Loading challenge ${challenge.id}`)
+          // logger.debug(`Loading challenge ${challenge.id}`)
           const c = await challengeService.getMMatchFromV4API(challenge.id)
           if (!c) {
             logger.warn(`Challenge Not Found in v4 API - ID: ${challenge.id}`)
+            missingIds.push(challenge.id)
             continue
           }
+          continue
 
           const v5ChallengeLookup = await challengeService.getChallengeIDsFromV5({ legacyId: challenge.id }, 10)
           // logger.debug(JSON.stringify(v5ChallengeLookup))
@@ -195,6 +198,7 @@ const migrationFunction = {
       page++
       batch++
     }
+    console.log('Missing IDs', missingIds)
   }
 }
 

src/services/challengeService.js

@@ -72,8 +72,9 @@ async function createChallenge (challenge) {
  */
 async function updateChallenge (challenge) {
   try {
+    const updateChallenge = new Challenge(_.omit(challenge, ['created', 'createdBy']))
     // numOfSubmissions and numOfRegistrants are not stored in dynamo, they're calclated by the ES processor
-    await Challenge.update({ id: challenge.id }, _.omit(challenge, challengePropertiesToOmitFromDynamo))
+    await Challenge.update({ id: challenge.id }, _.omit(updateChallenge, challengePropertiesToOmitFromDynamo))
     await getESClient().update({
       index: config.get('ES.CHALLENGE_ES_INDEX'),
       type: config.get('ES.CHALLENGE_ES_TYPE'),

src/services/syncService.js

@@ -47,8 +47,8 @@ async function processChallenge (legacyId, challengeListing, challengeDetails) {
   const v5ChallengeObjectFromV4 = await challengeService.buildV5Challenge(legacyId, challengeListing, challengeDetails)
   const [v5ChallengeFromAPI] = await challengeService.getChallengeFromV5API(legacyId)
 
-  logger.debug(`V5 Object Built from V4: ${JSON.stringify(v5ChallengeObjectFromV4)}`)
-  logger.debug(`V5 Object from API: ${JSON.stringify(v5ChallengeFromAPI)}`)
+  // logger.debug(`V5 Object Built from V4: ${JSON.stringify(v5ChallengeObjectFromV4)}`)
+  // logger.debug(`V5 Object from API: ${JSON.stringify(v5ChallengeFromAPI)}`)
 
   const additionalInformation = {}
 
@@ -87,14 +87,23 @@ async function processChallenge (legacyId, challengeListing, challengeDetails) {
     ommittedFields.push('privateDescription')
   }
   const challengeV4Prizes = _.get(v5ChallengeObjectFromV4, 'prizeSets', [])
-  logger.debug(`v4 prizes: ${JSON.stringify(challengeV4Prizes)}`)
+  // logger.debug(`v4 prizes: ${JSON.stringify(challengeV4Prizes)}`)
   const challengeV5APIPrizes = _.get(v5ChallengeFromAPI, 'prizeSets', [])
+<<<<<<< Updated upstream
   logger.debug(`v5 prizes: ${JSON.stringify(challengeV5APIPrizes)}`)
   const prizeSets = _.filter([
     ..._.intersectionBy(challengeV4Prizes, challengeV5APIPrizes, 'type'),
     ..._.differenceBy(challengeV5APIPrizes, challengeV4Prizes, 'type')
   ], entry => entry.type !== config.COPILOT_PAYMENT_TYPE)
   logger.debug(`intersection: ${JSON.stringify(prizeSets)}`)
+=======
+  // logger.debug(`v5 prizes: ${JSON.stringify(challengeV5APIPrizes)}`)
+  const prizeSets = [
+    ..._.intersectionBy(challengeV4Prizes, challengeV5APIPrizes, 'type'),
+    ..._.differenceBy(challengeV5APIPrizes, challengeV4Prizes, 'type')
+  ]
+  // logger.debug(`intersection: ${JSON.stringify(prizeSets)}`)
+>>>>>>> Stashed changes
 
   const copilotPayment = await challengeIfxService.getCopilotPaymentFromIfx(legacyId)
   if (copilotPayment) {
@@ -115,7 +124,7 @@ async function processChallenge (legacyId, challengeListing, challengeDetails) {
     prizeSets,
     ...additionalInformation
   }
-  logger.debug(`new V5 Object: ${JSON.stringify(updatedV5Object)}`)
+  // logger.debug(`new V5 Object: ${JSON.stringify(updatedV5Object)}`)
   return challengeService.save(updatedV5Object)
 }