Removing NaN from combined array

Author: rootelement

src/controllers/syncController.js

@@ -1,7 +1,7 @@
 const config = require('config')
 const logger = require('../util/logger')
 // const moment = require('moment')
-const { slice, union, toString, toNumber } = require('lodash')
+const { slice, union, toString, toNumber, remove } = require('lodash')
 const challengeSyncStatusService = require('../services/challengeSyncStatusService')
 const challengeSyncHistoryService = require('../services/challengeSyncHistoryService')
 const syncService = require('../services/syncService')
@@ -77,13 +77,14 @@ async function queueChallenges (filter) {
   // get active challenges from v4
   const { ids: v4IdArray } = await syncService.getV4ChallengeIds(filter)
   // console.log('v4', v4IdArray)
-  logger.debug(`v4 Array ${v4IdArray}`)
+  // logger.debug(`v4 Array ${v4IdArray}`)
   // get active challenges from v5
   const { ids: v5IdArray } = await syncService.getV5LegacyChallengeIds(filter)
-  logger.debug(`v5 Array ${v5IdArray}`)
+  // logger.debug(`v5 Array ${v5IdArray}`)
 
   // combine arrays, return unique
   const combinedArray = union(v4IdArray, v5IdArray)
+  remove(combinedArray, n => toString(n) === 'NaN')
   const totalChallengesCount = combinedArray.length
   // console.log('union length', combinedArray.length)