Skip to content
This repository was archived by the owner on Jan 23, 2025. It is now read-only.

Commit 0e761b2

Browse files
authored
Merge pull request #437 from deedee/effort-days
Change column name enable_effort_hours and Effort Estimate label
2 parents e27b64f + bf6f9bd commit 0e761b2

File tree

9 files changed

+22
-14
lines changed

9 files changed

+22
-14
lines changed

services/client_project_entities_dao/src/java/main/com/topcoder/clients/dao/ejb3/ProjectDAOBean.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -124,7 +124,7 @@ public class ProjectDAOBean extends GenericEJB3DAO<Project, Long> implements
124124
private static final String SELECT_PROJECT = "select p.project_id, p.name, p.po_box_number, p.description, "
125125
+ " p.active, p.sales_tax, p.payment_terms_id, p.modification_user, p.modification_date, "
126126
+ " p.creation_date, p.creation_user, p.is_deleted, "
127-
+ " cp.client_id, c.name as client_name, p.is_manual_prize_setting, c.code_name, c.enable_effort_hours "
127+
+ " cp.client_id, c.name as client_name, p.is_manual_prize_setting, c.code_name, c.enable_effort_days "
128128
+ " from project as p left join client_project as cp on p.project_id = cp.project_id left join client c "
129129
+ " on c.client_id = cp.client_id and (c.is_deleted = 0 or c.is_deleted is null) "
130130
+ " where p.active = 1 and p.start_date <= current and current <= p.end_date ";
@@ -135,7 +135,7 @@ public class ProjectDAOBean extends GenericEJB3DAO<Project, Long> implements
135135
private static final String SELECT_PROJECT_BY_CLIENT_ID = "select p.project_id, p.name, p.po_box_number, p.description, "
136136
+ " p.active, p.sales_tax, p.payment_terms_id, p.modification_user, p.modification_date, "
137137
+ " p.creation_date, p.creation_user, p.is_deleted, "
138-
+ " cp.client_id, c.name as client_name, p.is_manual_prize_setting, c.code_name, c.enable_effort_hours "
138+
+ " cp.client_id, c.name as client_name, p.is_manual_prize_setting, c.code_name, c.enable_effort_days "
139139
+ " from project as p, client_project as cp, client as c "
140140
+ " where p.start_date <= current and current <= p.end_date "
141141
+ " and c.client_id = cp.client_id and (p.is_deleted = 0 or p.is_deleted is null) "

services/client_project_entities_dao/src/java/main/com/topcoder/clients/model/Client.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -104,14 +104,14 @@ public class Client extends AuditableEntity {
104104
* <p>
105105
* Through corresponding getter/setter methods. It is retrieved from
106106
* Client.enableEffortDays [Client.isEffortDaysEnabled()] and in table
107-
* client.enable_effort_hours.
107+
* client.enable_effort_days.
108108
* </p>
109109
* <p>
110110
* There are no restrictions at this moment. It can take any value.
111111
* OPTIONAL.
112112
* </p>
113113
*/
114-
@Column(name = "enable_effort_hours")
114+
@Column(name = "enable_effort_days")
115115
private Boolean enableEffortDays;
116116

117117
/**

src/web/WEB-INF/contest-details2.jsp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -187,7 +187,7 @@
187187
</div><!-- End .tooltipCaption -->
188188

189189
<div class="tooltipContent">
190-
<p>Effort Days Estimate</p>
190+
<p>onsite efforts in person days * 6 + offshore efforts in person days</p>
191191
</div><!-- End .tooltipContent -->
192192

193193
</div></div>

src/web/WEB-INF/includes/contest/editTab.jsp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -163,7 +163,7 @@
163163
</tr>
164164
<tr></tr>
165165
<tr class="effortEstimateRow hide">
166-
<td class="first_tab_type"><strong>Effort Days Estimate</strong></td>
166+
<td class="first_tab_type"><strong>Estimated Effort<br/>(in Person Days):</strong></td>
167167
<td class="sec_tab_type"><strong>: <span id="rEffortDaysEstimate"></span></strong></td>
168168
</tr>
169169
<tr></tr>
@@ -342,7 +342,7 @@
342342
</div>
343343
<br/><br/>
344344
<div class="effortEstimateRow">
345-
<span class="name fixWidthName" title="Enter effort days estimate"><strong>Estimated Effort:&nbsp;</strong><a href="javascript:;" class="helpme"><img src="/images/help_ico5.gif" alt="help"/></a></span>
345+
<span class="name fixWidthName" title="Enter effort days estimate"><strong>Estimated Effort<br/>(in Person Days):&nbsp;</strong><a href="javascript:;" class="helpme"><img src="/images/help_ico5.gif" alt="help"/></a></span>
346346
<input id="effortDaysEstimate" class="bigin" name="effortDaysEstimate" type="text" value="" />
347347
</div>
348348
<br/><br/>

src/web/WEB-INF/includes/contest/editTabMarathon.jsp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -135,7 +135,7 @@
135135
</tr>
136136
<tr></tr>
137137
<tr class="effortEstimateRow hide">
138-
<td class="first_tab_type"><strong>Effort Hours Estimate</strong></td>
138+
<td class="first_tab_type"><strong>Estimated Effort<br/>(in Person Days):</strong></td>
139139
<td class="sec_tab_type"><strong>: <span id="rEffortDaysEstimate"></span></strong></td>
140140
</tr>
141141
<tr></tr>
@@ -295,7 +295,7 @@
295295
</div>
296296
<br /><br />
297297
<div class="effortEstimateRow">
298-
<span class="name fixWidthName" title="Enter effort days estimate"><strong>Estimated Effort:&nbsp;</strong><a href="javascript:;" class="helpme"><img src="/images/help_ico5.gif" alt="help"/></a></span>
298+
<span class="name fixWidthName" title="Enter effort days estimate"><strong>Estimated Effort<br/>(in Person Days):&nbsp;</strong><a href="javascript:;" class="helpme"><img src="/images/help_ico5.gif" alt="help"/></a></span>
299299
<input id="effortDaysEstimate" class="bigin" name="effortDaysEstimate" type="text" value="" />
300300
</div>
301301
<br/><br/>

src/web/WEB-INF/includes/contest/editTabSoftware.jsp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -185,7 +185,7 @@
185185
</tr>
186186
<tr></tr>
187187
<tr class="effortEstimateRow hide">
188-
<td class="first_tab_type"><strong>Effort Days Estimate</strong></td>
188+
<td class="first_tab_type"><strong>Estimated Effort<br/>(in Person Days):</strong></td>
189189
<td class="sec_tab_type"><strong>: <span id="rEffortDaysEstimate"></span></strong></td>
190190
</tr>
191191
<tr></tr>
@@ -369,7 +369,7 @@
369369
<br/>
370370

371371
<div class="effortEstimateRow">
372-
<span class="name fixWidthName" title="Enter effort days estimate"><strong>Estimated Effort:&nbsp;</strong><a href="javascript:;" class="helpme"><img src="/images/help_ico5.gif" alt="help"/></a></span>
372+
<span class="name fixWidthName" title="Enter effort days estimate"><strong>Estimated Effort<br/>(in Person Days):&nbsp;</strong><a href="javascript:;" class="helpme"><img src="/images/help_ico5.gif" alt="help"/></a></span>
373373
<input id="effortDaysEstimate" class="bigin" name="effortDaysEstimate" type="text" value="" />
374374
<br/>
375375
<br/>

src/web/WEB-INF/includes/launch/contestSelection.jsp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -237,7 +237,7 @@
237237
</div>
238238
</div>
239239
<div class="ms-row effortEstimateRow">
240-
<label>Estimated Effort:&nbsp;&nbsp;<a href="javascript:;" class="helpme"><img src="/images/help_ico5.gif" alt="help"/></a></label>
240+
<label>Estimated Effort<br/>(in Person Days):&nbsp;&nbsp;<a href="javascript:;" class="helpme"><img src="/images/help_ico5.gif" alt="help"/></a></label>
241241
<input id="effortDaysEstimate" class="text" name="effortDaysEstimate" type="text"/>
242242
</div>
243243
</div>

src/web/WEB-INF/launch-contest.jsp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -167,7 +167,7 @@
167167
</div><!-- End .tooltipCaption -->
168168

169169
<div class="tooltipContent">
170-
<p>Effort Days Estimate</strong></p>
170+
<p>onsite efforts in person days * 6 + offshore efforts in person days</p>
171171
</div><!-- End .tooltipContent -->
172172

173173
</div></div>

src/web/css/direct/launchcontest.css

Lines changed: 9 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -309,7 +309,7 @@
309309
margin-left: 14px;
310310
font-family: "Source Sans Pro", Arial, Helvetica, sans-serif;
311311
font-size: 14px;
312-
line-height: 28px;
312+
line-height: 24px;
313313
}
314314

315315
#launchContestOut.launchCopilotContest .addNewContest label {
@@ -3256,6 +3256,10 @@ div.ms-group-display .ms-group-div{
32563256
margin-top: 17px;
32573257
}
32583258

3259+
.effortEstimateRow {
3260+
height: 50px;
3261+
}
3262+
32593263
.dropdown-menu {
32603264
position: absolute;
32613265
top: 100%;
@@ -3287,3 +3291,7 @@ div.ms-group-display .ms-group-div{
32873291
width: 401px;
32883292
height: 25px;
32893293
}
3294+
3295+
span.name.fixWidthName {
3296+
line-height: 24px;
3297+
}

0 commit comments

Comments
 (0)