fix: clean up endpoint masking

Author: mikesmitty

src/machine/machine_rp2_usb.go

@@ -152,23 +152,25 @@ func sendViaEPIn(ep uint32, data []byte, count int) {
 
 // Set ENDPOINT_HALT/stall status on a USB IN endpoint.
 func (dev *USBDevice) SetStallEPIn(ep uint32) {
+	ep = ep & 0x7F
 	// Prepare buffer control register value
 	if ep == 0 {
 		armEPZeroStall()
 	}
 	val := uint32(usbBuf0CtrlFull)
-	_usbDPSRAM.EPxBufferControl[ep&0x7F].In.Set(val)
+	_usbDPSRAM.EPxBufferControl[ep].In.Set(val)
 	val |= uint32(usbBuf0CtrlStall)
-	_usbDPSRAM.EPxBufferControl[ep&0x7F].In.Set(val)
+	_usbDPSRAM.EPxBufferControl[ep].In.Set(val)
 }
 
 // Set ENDPOINT_HALT/stall status on a USB OUT endpoint.
 func (dev *USBDevice) SetStallEPOut(ep uint32) {
+	ep = ep & 0x7F
 	if ep == 0 {
 		panic("SetStallEPOut: EP0 OUT not valid")
 	}
 	val := uint32(usbBuf0CtrlStall)
-	_usbDPSRAM.EPxBufferControl[ep&0x7F].Out.Set(val)
+	_usbDPSRAM.EPxBufferControl[ep].Out.Set(val)
 }
 
 // Clear the ENDPOINT_HALT/stall on a USB IN endpoint.
@@ -178,7 +180,7 @@ func (dev *USBDevice) ClearStallEPIn(ep uint32) {
 	_usbDPSRAM.EPxBufferControl[ep].In.ClearBits(val)
 	if epXPIDReset[ep] {
 		// Reset the PID to DATA0
-		setEPDataPID(ep&0x7F, false)
+		setEPDataPID(ep, false)
 	}
 }