Upgrade kuromojin #2
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
azu
reviewed
Dec 31, 2020
src/no-dropping-i.js
Outdated
| import { RuleHelper } from "textlint-rule-helper"; | ||
| import kuromojin from "kuromojin"; | ||
| const { RuleHelper } = require("textlint-rule-helper"); | ||
| const kuromojin = require("kuromojin"); |
There was a problem hiding this comment.
When I use import kuromojin from "kuromojin";, the following error occured in yarn test.
1) no-dropping-i
見てます。:
TypeError: Cannot read property 'tokenize' of undefined
at /home/hata/textlint-rule-no-dropping-i/src/no-dropping-i.js:23:30
at /home/hata/textlint-rule-no-dropping-i/node_modules/@textlint/kernel/src/task/promise-event-emitter.ts:27:35
at Array.forEach (<anonymous>)
at RuleTypeEmitter.PromiseEventEmitter.emit (node_modules/@textlint/kernel/src/task/promise-event-emitter.ts:26:38)
at Controller.enter (node_modules/@textlint/kernel/src/task/textlint-core-task.ts:157:53)
at Controller.__execute (node_modules/@textlint/ast-traverse/src/index.ts:51:31)
at Controller.traverse (node_modules/@textlint/ast-traverse/src/index.ts:132:28)
at TextLintCoreTask.startTraverser (node_modules/@textlint/kernel/src/task/textlint-core-task.ts:152:28)
at TextLintCoreTask.start (node_modules/@textlint/kernel/src/task/linter-task.ts:43:14)
at /home/hata/textlint-rule-no-dropping-i/node_modules/@textlint/kernel/src/task/task-runner.ts:28:18
at new Promise (<anonymous>)
at Function.TaskRunner.process (node_modules/@textlint/kernel/src/task/task-runner.ts:16:16)
at LinterProcessor.process (node_modules/@textlint/kernel/src/linter/linter-processor.ts:55:27)
at TextlintKernel._parallelProcess (node_modules/@textlint/kernel/src/textlint-kernel.ts:155:14)
at /home/hata/textlint-rule-no-dropping-i/node_modules/@textlint/kernel/src/textlint-kernel.ts:83:25
And, it seems src/no-dropping-i.js uses CommonJS module.exports.
module.exports = function(context) {
So, I rewrote to CommonJS require().
Alternative solution: import * as
import * as kuromojin from "kuromojin";
いつも Twitter 経由で JSer.info を見させてもらっています。
本年はありがとうございました。
There was a problem hiding this comment.
tokenize is named exports.
We should use named import to import tokenize.
import { tokenize } from "kuromoji"
I like es imports.
There was a problem hiding this comment.
📝 We will change exports to export default, but it requires major updates.
(also rewrite it by TypeScript?)
There was a problem hiding this comment.
Fixed to use ESModules import.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.