From 7074ba53c498006f8f8e9429a81e0e7746dcfdbb Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Adri=C3=A0=20Fontcuberta?= Date: Sat, 20 Jun 2020 08:38:46 +0200 Subject: [PATCH 1/9] Add links to issues and discord --- README.md | 36 +++++++++++++++++++++++++++++++++--- 1 file changed, 33 insertions(+), 3 deletions(-) diff --git a/README.md b/README.md index 3d350f0c..5b071491 100644 --- a/README.md +++ b/README.md @@ -33,7 +33,6 @@ [![npm version][npm-badge]][npm] [![MIT License][license-badge]][license] -[![Join the community on Spectrum][spectrum-badge]][spectrum]

Table of Contents

@@ -47,6 +46,10 @@ - [Docs](#docs) - [Typings](#typings) - [ESLint support](#eslint-support) +- [Issues](#issues) + - [🐛 Bugs](#-bugs) + - [💡 Feature Requests](#-feature-requests) + - [❓ Questions](#-questions) - [License](#license) - [Contributors](#contributors) @@ -145,6 +148,30 @@ bundled with Vue Testing Library. If you want to lint test files that use Vue Testing Library, you can use the official plugin: [eslint-plugin-testing-library][eslint-plugin-testing-library]. +## Issues + +_Looking to contribute? Look for the [Good First Issue][good-first-issue] +label._ + +### 🐛 Bugs + +Please [file an issue][add-issue-bug] for bugs, missing documentation, or +unexpected behavior. + +[**See Bugs**][bugs] + +### 💡 Feature Requests + +Please [file an issue][add-issue] to suggest new features. Vote on feature +requests by adding a 👍. This helps maintainers prioritize what to work on. + +### ❓ Questions + +For questions related to using the library, please visit a support community +instead of filling an issue on GitHub. + +- [Discord][discord] + ## License [MIT][license] @@ -178,8 +205,6 @@ official plugin: [eslint-plugin-testing-library][eslint-plugin-testing-library]. [build-badge]: https://travis-ci.org/testing-library/vue-testing-library.svg?branch=master [build]: https://travis-ci.org/testing-library/vue-testing-library -[spectrum-badge]: https://withspectrum.github.io/badge/badge.svg -[spectrum]: https://spectrum.chat/testing-library [coverage-badge]: https://img.shields.io/codecov/c/github/testing-library/vue-testing-library.svg [coverage]: https://codecov.io/github/testing-library/vue-testing-library [github-badge]: https://badge.fury.io/gh/testing-library%2Fvue-testing-library.svg @@ -189,11 +214,16 @@ official plugin: [eslint-plugin-testing-library][eslint-plugin-testing-library]. [license-badge]: https://img.shields.io/github/license/testing-library/vue-testing-library.svg [license]: https://github.com/testing-library/vue-testing-library/blob/master/LICENSE [types]: https://github.com/DefinitelyTyped/DefinitelyTyped/tree/master/types/testing-library__vue +[discord]: https://testing-library.com/discord [docs]: https://testing-library.com/vue [docs-edit]: https://github.com/testing-library/testing-library-docs [eslint-plugin-testing-library]: https://github.com/testing-library/eslint-plugin-testing-library +[bugs]: https://github.com/testing-library/vue-testing-library/issues?q=is%3Aissue+is%3Aopen+label%3Abug+sort%3Acreated-desc +[add-issue-bug]: https://github.com/testing-library/vue-testing-library/issues/new?assignees=&labels=bug&template=bug_report.md&title= +[add-issue]: (https://github.com/testing-library/vue-testing-library/issues/new) + [test-directory]: https://github.com/testing-library/vue-testing-library/blob/master/src/__tests__ [vuex-example]: https://github.com/testing-library/vue-testing-library/blob/master/src/__tests__/vuex.js [vue-router-example]: https://github.com/testing-library/vue-testing-library/blob/master/src/__tests__/vue-router.js From c2a1c9a8bf642fc77fc03790985e821499cce9e7 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Adri=C3=A0=20Fontcuberta?= Date: Sat, 20 Jun 2020 08:57:38 +0200 Subject: [PATCH 2/9] Improve example to use screen --- README.md | 70 ++++++++++++++++++++++++++++++++++++++++++------------- 1 file changed, 54 insertions(+), 16 deletions(-) diff --git a/README.md b/README.md index 5b071491..7e8b2eba 100644 --- a/README.md +++ b/README.md @@ -41,8 +41,9 @@ - [Installation](#installation) -- [A simple example](#a-simple-example) +- [A basic example](#a-basic-example) - [More examples](#more-examples) +- [Guiding Principles](#guiding-principles) - [Docs](#docs) - [Typings](#typings) - [ESLint support](#eslint-support) @@ -67,10 +68,10 @@ npm install --save-dev @testing-library/vue This library has `peerDependencies` listings for `Vue` and `vue-template-compiler`. -You may also be interested in installing `jest-dom` so you can use -[the custom Jest matchers](https://github.com/testing-library/jest-dom#readme). +You may also be interested in installing `jest-dom` so you can use [the custom +Jest matchers][jest-dom]. -## A simple example +## A basic example ```html @@ -83,6 +84,7 @@ You may also be interested in installing `jest-dom` so you can use