Identify TODOs

Author: afontcu

src/vue-testing-library.js

@@ -1,5 +1,6 @@
 /* eslint-disable testing-library/no-wait-for-empty-callback */
-import {createLocalVue, mount} from '@vue/test-utils'
+import {mount} from '@vue/test-utils'
+// import {createLocalVue, mount} from '@vue/test-utils'
 
 import {
   getQueriesForElement,
@@ -21,35 +22,38 @@ function render(
   } = {},
   configurationCb,
 ) {
+  // TODO: Can we simplify this by using attachTo?
   const div = document.createElement('div')
   const baseElement = customBaseElement || customContainer || document.body
   const container = customContainer || baseElement.appendChild(div)
 
   const attachTo = document.createElement('div')
   container.appendChild(attachTo)
 
-  const localVue = createLocalVue()
+  // const localVue = createLocalVue()
   let vuexStore = null
   let router = null
   let additionalOptions = {}
 
+  // TODO: Fix VTL + Vuex (v4?)
   if (store) {
     const Vuex = require('vuex')
-    localVue.use(Vuex)
+    // localVue.use(Vuex)
     vuexStore = new Vuex.Store(store)
   }
 
+  // TODO: Fix VTL + Vue-router(next?)
   if (routes) {
     const requiredRouter = require('vue-router')
     const VueRouter = requiredRouter.default || requiredRouter
-    localVue.use(VueRouter)
+    // localVue.use(VueRouter)
     router = new VueRouter({
       routes,
     })
   }
 
   if (configurationCb && typeof configurationCb === 'function') {
-    additionalOptions = configurationCb(localVue, vuexStore, router)
+    additionalOptions = configurationCb(vuexStore, router)
   }
 
   if (!mountOptions.propsData && !!mountOptions.props) {
@@ -58,10 +62,10 @@ function render(
   }
 
   const wrapper = mount(TestComponent, {
-    localVue,
-    router,
+    // localVue,
+    // router,
+    // store: vuexStore,
     attachTo,
-    store: vuexStore,
     ...mountOptions,
     ...additionalOptions,
   })
@@ -74,10 +78,14 @@ function render(
     baseElement,
     debug: (el = baseElement) =>
       Array.isArray(el) ? el.forEach(e => logDOM(e)) : logDOM(el),
-    unmount: () => wrapper.destroy(),
-    isUnmounted: () => wrapper.vm._isDestroyed,
+    unmount: () => wrapper.unmount(),
+    // isUnmounted: () => wrapper.vm._isDestroyed,
     html: () => wrapper.html(),
     emitted: () => wrapper.emitted(),
+
+    // TODO: Is this unnecessary now? No need to await for a tick because
+    //       setProps() handles it for us now.
+    // We can simply expose setProps.
     updateProps: _ => {
       wrapper.setProps(_)
       return waitFor(() => {})