From 6044e37f73cd67b6ff238f13485e3a1c87663c52 Mon Sep 17 00:00:00 2001 From: Nick McCurdy Date: Thu, 1 Jul 2021 12:58:40 -0400 Subject: [PATCH 1/2] chore: upgrade to Jest 27 --- package.json | 3 ++- src/__tests__/multi-base.test.js | 40 +++++++++++++++++++------------- 2 files changed, 26 insertions(+), 17 deletions(-) diff --git a/package.json b/package.json index e831adf..71173c3 100644 --- a/package.json +++ b/package.json @@ -74,7 +74,7 @@ "eslint-plugin-simple-import-sort": "^7.0.0", "eslint-plugin-svelte3": "^3.0.0", "husky": "^4.0.9", - "jest": "^26.0.1", + "jest": "^27.0.6", "lint-staged": "^10.0.0", "npm-run-all": "^4.1.5", "prettier": "^2.0.1", @@ -118,6 +118,7 @@ "setupFilesAfterEnv": [ "@testing-library/jest-dom/extend-expect" ], + "testEnvironment": "jsdom", "transform": { "^.+\\.js$": "babel-jest", "^.+\\.svelte$": "svelte-jester", diff --git a/src/__tests__/multi-base.test.js b/src/__tests__/multi-base.test.js index ec9307c..c270433 100644 --- a/src/__tests__/multi-base.test.js +++ b/src/__tests__/multi-base.test.js @@ -13,28 +13,36 @@ describe('multi-base', () => { }) afterAll(() => { - treeA.parentNode.removeChild(treeA) - treeB.parentNode.removeChild(treeB) + treeA = document.createElement('div') + treeB = document.createElement('div') }) test('container isolates trees from one another', () => { - const { getByText: getByTextInA } = render(Comp, { - target: treeA, - props: { - name: 'Tree A' + const { getByText: getByTextInA } = render( + Comp, + { + target: treeA, + props: { + name: 'Tree A' + } + }, + { + container: treeA } - }, { - container: treeA - }) + ) - const { getByText: getByTextInB } = render(Comp, { - target: treeB, - props: { - name: 'Tree B' + const { getByText: getByTextInB } = render( + Comp, + { + target: treeB, + props: { + name: 'Tree B' + } + }, + { + container: treeB } - }, { - container: treeB - }) + ) expect(() => getByTextInA('Hello Tree A!')).not.toThrow() expect(() => getByTextInB('Hello Tree A!')).toThrow() From 96d47d4d676d50e29816823bbbd8aca959868873 Mon Sep 17 00:00:00 2001 From: Nick McCurdy Date: Thu, 1 Jul 2021 13:01:36 -0400 Subject: [PATCH 2/2] chore: revert formatting --- src/__tests__/multi-base.test.js | 36 +++++++++++++------------------- 1 file changed, 14 insertions(+), 22 deletions(-) diff --git a/src/__tests__/multi-base.test.js b/src/__tests__/multi-base.test.js index c270433..4031275 100644 --- a/src/__tests__/multi-base.test.js +++ b/src/__tests__/multi-base.test.js @@ -18,31 +18,23 @@ describe('multi-base', () => { }) test('container isolates trees from one another', () => { - const { getByText: getByTextInA } = render( - Comp, - { - target: treeA, - props: { - name: 'Tree A' - } - }, - { - container: treeA + const { getByText: getByTextInA } = render(Comp, { + target: treeA, + props: { + name: 'Tree A' } - ) + }, { + container: treeA + }) - const { getByText: getByTextInB } = render( - Comp, - { - target: treeB, - props: { - name: 'Tree B' - } - }, - { - container: treeB + const { getByText: getByTextInB } = render(Comp, { + target: treeB, + props: { + name: 'Tree B' } - ) + }, { + container: treeB + }) expect(() => getByTextInA('Hello Tree A!')).not.toThrow() expect(() => getByTextInB('Hello Tree A!')).toThrow()