From 8bea590901715395200fe3d4941510f45d0a5ebb Mon Sep 17 00:00:00 2001 From: eps1lon Date: Tue, 1 Mar 2022 19:44:35 +0100 Subject: [PATCH 1/8] chore: Fix failing codesandbox/ci --- .codesandbox/ci.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.codesandbox/ci.json b/.codesandbox/ci.json index f866879a..e76b68db 100644 --- a/.codesandbox/ci.json +++ b/.codesandbox/ci.json @@ -1,4 +1,4 @@ { "sandboxes": ["new", "github/kentcdodds/react-testing-library-examples"], - "node": "12" + "node": "16" } From c8ba1a47134654741cf76a79eb2a45d0322dfdcd Mon Sep 17 00:00:00 2001 From: eps1lon Date: Tue, 1 Mar 2022 19:50:13 +0100 Subject: [PATCH 2/8] force npm --- .codesandbox/ci.json | 1 + 1 file changed, 1 insertion(+) diff --git a/.codesandbox/ci.json b/.codesandbox/ci.json index e76b68db..abae1ec1 100644 --- a/.codesandbox/ci.json +++ b/.codesandbox/ci.json @@ -1,4 +1,5 @@ { "sandboxes": ["new", "github/kentcdodds/react-testing-library-examples"], + "install": "npm install", "node": "16" } From b779e7f5ea7a22d9598b0a63a6b56255e6779b23 Mon Sep 17 00:00:00 2001 From: eps1lon Date: Tue, 1 Mar 2022 19:53:38 +0100 Subject: [PATCH 3/8] evict possibly bad cache --- .codesandbox/ci.json | 3 +-- package.json | 2 +- 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/.codesandbox/ci.json b/.codesandbox/ci.json index abae1ec1..f866879a 100644 --- a/.codesandbox/ci.json +++ b/.codesandbox/ci.json @@ -1,5 +1,4 @@ { "sandboxes": ["new", "github/kentcdodds/react-testing-library-examples"], - "install": "npm install", - "node": "16" + "node": "12" } diff --git a/package.json b/package.json index cbf61367..f7c1c8f2 100644 --- a/package.json +++ b/package.json @@ -51,7 +51,7 @@ "@testing-library/jest-dom": "^5.11.6", "@types/react-dom": "^17.0.0", "dotenv-cli": "^4.0.0", - "kcd-scripts": "^11.1.0", + "kcd-scripts": "^11.2.2", "npm-run-all": "^4.1.5", "react": "^17.0.1", "react-dom": "^17.0.1", From 4595a0e71f76f3783e41f919ae4181afe93fa43d Mon Sep 17 00:00:00 2001 From: eps1lon Date: Tue, 1 Mar 2022 20:06:05 +0100 Subject: [PATCH 4/8] More force --- .codesandbox/ci.json | 1 + 1 file changed, 1 insertion(+) diff --git a/.codesandbox/ci.json b/.codesandbox/ci.json index f866879a..aa8dd996 100644 --- a/.codesandbox/ci.json +++ b/.codesandbox/ci.json @@ -1,4 +1,5 @@ { + "install": "install --force --no-lockfile", "sandboxes": ["new", "github/kentcdodds/react-testing-library-examples"], "node": "12" } From 091b64ea3d340f441340be59cc2b9e907bf7f907 Mon Sep 17 00:00:00 2001 From: eps1lon Date: Tue, 1 Mar 2022 20:07:56 +0100 Subject: [PATCH 5/8] install -> installCommand --- .codesandbox/ci.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.codesandbox/ci.json b/.codesandbox/ci.json index aa8dd996..e43bfc3b 100644 --- a/.codesandbox/ci.json +++ b/.codesandbox/ci.json @@ -1,5 +1,5 @@ { - "install": "install --force --no-lockfile", + "installCommand": "npm install --force --no-lockfile", "sandboxes": ["new", "github/kentcdodds/react-testing-library-examples"], "node": "12" } From 1f0b7c7c48dc4f7b34f254241fe1f10bbda83afb Mon Sep 17 00:00:00 2001 From: eps1lon Date: Tue, 1 Mar 2022 20:09:20 +0100 Subject: [PATCH 6/8] 0-zero config requires the existence of >0-config. Otherwise your 0-config is almost certainly bad. --- .codesandbox/ci.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.codesandbox/ci.json b/.codesandbox/ci.json index e43bfc3b..2f72126d 100644 --- a/.codesandbox/ci.json +++ b/.codesandbox/ci.json @@ -1,5 +1,5 @@ { - "installCommand": "npm install --force --no-lockfile", + "installCommand": "install --force --no-lockfile", "sandboxes": ["new", "github/kentcdodds/react-testing-library-examples"], "node": "12" } From 442dd199f7e21b1ef6ab83504b2358b84093dcd5 Mon Sep 17 00:00:00 2001 From: eps1lon Date: Tue, 1 Mar 2022 20:10:25 +0100 Subject: [PATCH 7/8] Ok this works --- .codesandbox/ci.json | 2 +- package.json | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/.codesandbox/ci.json b/.codesandbox/ci.json index 2f72126d..bf3237bb 100644 --- a/.codesandbox/ci.json +++ b/.codesandbox/ci.json @@ -1,5 +1,5 @@ { - "installCommand": "install --force --no-lockfile", + "installCommand": "install:csb", "sandboxes": ["new", "github/kentcdodds/react-testing-library-examples"], "node": "12" } diff --git a/package.json b/package.json index f7c1c8f2..f146eeed 100644 --- a/package.json +++ b/package.json @@ -15,6 +15,7 @@ "build:bundle:pure": "dotenv -e .bundle.main.env -e .bundle.pure.env kcd-scripts build -- --bundle --no-clean", "build:main": "kcd-scripts build --no-clean", "format": "kcd-scripts format", + "install:csb": "npm install", "lint": "kcd-scripts lint", "setup": "npm install && npm run validate -s", "test": "kcd-scripts test", From f822d8c40435fb328cbf5a682ee719da0b5242d6 Mon Sep 17 00:00:00 2001 From: eps1lon Date: Tue, 1 Mar 2022 20:14:06 +0100 Subject: [PATCH 8/8] git-diff hygiene --- package.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/package.json b/package.json index f146eeed..55b31ec0 100644 --- a/package.json +++ b/package.json @@ -52,7 +52,7 @@ "@testing-library/jest-dom": "^5.11.6", "@types/react-dom": "^17.0.0", "dotenv-cli": "^4.0.0", - "kcd-scripts": "^11.2.2", + "kcd-scripts": "^11.1.0", "npm-run-all": "^4.1.5", "react": "^17.0.1", "react-dom": "^17.0.1",