Skip to content

Commit 4763ffb

Browse files
author
Kent C. Dodds
authored
fix(TS): make container optional in RenderOptions (#253)
**What**: TS: make container optional in RenderOptions <!-- Why are these changes necessary? --> **Why**: Particularly useful if you're making a custom render with custom options. If you extend the type and call your custom render without the container but with the other options then you get a false error. <!-- How were these changes implemented? --> **How**: `?` <!-- Have you done all of these things? --> **Checklist**: <!-- add "N/A" to the end of each line that's irrelevant to your changes --> <!-- to check an item, place an "x" in the box like so: "- [x] Documentation" --> - [ ] Documentation N/A - [ ] Tests N/A - [x] Ready to be merged <!-- In your opinion, is this ready to be merged as soon as it's reviewed? --> - [ ] Added myself to contributors table N/A <!-- this is optional, see the contributing guidelines for instructions --> <!-- feel free to add additional comments -->
1 parent f099d2f commit 4763ffb

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

typings/index.d.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ export interface RenderResult extends GetsAndQueries {
1414
}
1515

1616
export interface RenderOptions {
17-
container: HTMLElement
17+
container?: HTMLElement
1818
baseElement?: HTMLElement
1919
hydrate?: boolean
2020
}

0 commit comments

Comments
 (0)