style: fix some lint related things

Author: jrolfs

lib/extend.ts

@@ -4,7 +4,7 @@ import {getDocument, getQueriesForElement} from '.'
 import {ElementHandle, IScopedQueryUtils} from './typedefs'
 
 let Page
-let ElementHandle // eslint-disable-line no-redeclare
+let ElementHandle // eslint-disable-line @typescript-eslint/no-redeclare
 
 function requireOrUndefined(path: string) {
   try {

lib/index.ts

@@ -97,12 +97,16 @@ async function processQuery(handles: IHandleSet): Promise<DOMReturnType> {
   try {
     const handle = await containerHandle.evaluateHandle(evaluateFn, [fnName, ...argsToForward])
     return await covertToElementHandle(handle, fnName.includes('All'))
-  } catch (err) {
-    err.message = err.message
-      .replace(/^.*(?=TestingLibraryElementError:)/, '')
-      .replace('[fnName]', `[${fnName}]`)
-    err.stack = err.stack.replace('[fnName]', `[${fnName}]`)
-    throw err
+  } catch (error) {
+    if (error instanceof Error) {
+      error.message = error.message
+        .replace(/^.*(?=TestingLibraryElementError:)/, '')
+        .replace('[fnName]', `[${fnName}]`)
+
+      error.stack = error.stack?.replace('[fnName]', `[${fnName}]`)
+    }
+
+    throw error
   }
 }
 

test/extend.test.ts

@@ -21,7 +21,7 @@ describe('lib/extend.ts', () => {
     document = await page.getDocument()
   })
 
-  it('should extend playwright ElementHandle', async () => {
+  it('should extend playwright ElementHandle', () => {
     expect(typeof document.queryAllByAltText).toBe('function')
   })
 

test/index.test.ts

@@ -33,14 +33,15 @@ describe('lib/index.ts', () => {
     expect(await queries.getNodeText(element)).toEqual('Hello h1')
   })
 
-  it('should keep the default data-testid when input passed is invalid', async () => {
-    ;[{}, undefined, null, {testIdAttribute: ''}].forEach(async options => {
+  it.each([{}, undefined, null, {testIdAttribute: ''}])(
+    'should keep the default data-testid when input passed is invalid',
+    async options => {
       const document = await getDocument(page)
       configure(options as any)
       const element = await queries.getByTestId(document, 'testid-label')
       expect(await queries.getNodeText(element)).toEqual('Label A')
-    })
-  })
+    },
+  )
 
   it('should support regex on raw queries object', async () => {
     const scope = await page.$('#scoped')
@@ -50,6 +51,9 @@ describe('lib/index.ts', () => {
   })
 
   it('should bind getQueriesForElement', async () => {
+    // FIXME: I think it will take some work to get the types in a
+    // place to prevent @typescript-eslint from flagging this
+    // eslint-disable-next-line @typescript-eslint/unbound-method
     const {getByText} = getQueriesForElement(await getDocument(page))
     const element = await getByText('Hello h1')
     expect(await queries.getNodeText(element)).toEqual('Hello h1')
@@ -59,6 +63,9 @@ describe('lib/index.ts', () => {
     beforeEach(async () => page.goto(`file://${path.join(__dirname, 'fixtures/late-page.html')}`))
 
     it('should use `wait` properly', async () => {
+      // FIXME: I think it will take some work to get the types in a
+      // place to prevent @typescript-eslint from flagging this
+      // eslint-disable-next-line @typescript-eslint/unbound-method
       const {getByText} = getQueriesForElement(await getDocument(page))
       // eslint-disable-next-line @typescript-eslint/no-misused-promises
       await waitFor(async () => expect(await getByText('Loaded!')).toBeTruthy(), {timeout: 7000})