refactor(no-unnecessary-act): function to find non-testing-library calls

Author: Belco90

lib/rules/no-unnecessary-act.ts

@@ -33,33 +33,26 @@ export default createTestingLibraryRule<[], MessageIds>({
 
   create(context, _, helpers) {
     /**
-     * Determines whether a given list of statements has some call non-related to Testing Library utils.
+     * Determines whether some call is non Testing Library related for a given list of statements.
      */
-    function hasNonTestingLibraryCall(
+    function hasSomeNonTestingLibraryCall(
       statements: TSESTree.Statement[]
     ): boolean {
-      // TODO: refactor to use Array.every
-      for (const statement of statements) {
+      return statements.some((statement) => {
         const callExpression = getStatementCallExpression(statement);
 
         if (!callExpression) {
-          continue;
+          return false;
         }
 
         const identifier = getDeepestIdentifierNode(callExpression);
 
         if (!identifier) {
-          continue;
+          return false;
         }
 
-        if (helpers.isTestingLibraryUtil(identifier)) {
-          continue;
-        }
-
-        // at this point the statement is a non testing library call
-        return true;
-      }
-      return false;
+        return !helpers.isTestingLibraryUtil(identifier);
+      });
     }
 
     function checkNoUnnecessaryActFromBlockStatement(
@@ -94,18 +87,12 @@ export default createTestingLibraryRule<[], MessageIds>({
           node: callExpressionIdentifier,
           messageId: 'noUnnecessaryActEmptyFunction',
         });
-
-        return;
-      }
-
-      if (hasNonTestingLibraryCall(blockStatementNode.body)) {
-        return;
+      } else if (!hasSomeNonTestingLibraryCall(blockStatementNode.body)) {
+        context.report({
+          node: callExpressionIdentifier,
+          messageId: 'noUnnecessaryActTestingLibraryUtil',
+        });
       }
-
-      context.report({
-        node: callExpressionIdentifier,
-        messageId: 'noUnnecessaryActTestingLibraryUtil',
-      });
     }
 
     function checkNoUnnecessaryActFromImplicitReturn(

tests/lib/rules/no-unnecessary-act.test.ts

@@ -373,6 +373,6 @@ ruleTester.run(RULE_NAME, rule, {
     // TODO case: RTU act wrapping RTL calls - callbacks with return
     // TODO case: RTU act wrapping empty callback
 
-    // TODO cases like previous ones but with AGR disabled
+    // TODO case: mixed scenarios - AGR disabled
   ],
 });