fix(await-async-query): check queries being called as member expressions

First, abstract a isQueryUsage function to check if a node should be checked for this rule. Then, add new selector
for queries being called as part of MemberExpression and check their parent against the rule. Finally, use the
queryName prop to make sure the right error message is printed

Author: victorandcode

lib/rules/await-async-query.js

@@ -28,18 +28,26 @@ module.exports = {
 
   create: function(context) {
     const testingLibraryQueryUsage = [];
+    const isQueryUsage = node =>
+      !isAwaited(node.parent.parent) &&
+      !isPromiseResolved(node) &&
+      !hasClosestExpectResolvesRejects(node);
+
     return {
       [`CallExpression > Identifier[name=${ASYNC_QUERIES_REGEXP}]`](node) {
-        if (
-          !isAwaited(node.parent.parent) &&
-          !isPromiseResolved(node) &&
-          !hasClosestExpectResolvesRejects(node)
-        ) {
-          testingLibraryQueryUsage.push(node);
+        if (isQueryUsage(node)) {
+          testingLibraryQueryUsage.push({ node, queryName: node.name });
+        }
+      },
+      [`MemberExpression > Identifier[name=${ASYNC_QUERIES_REGEXP}]`](node) {
+        // Perform checks in parent MemberExpression insted of current identifier
+        const parent = node.parent;
+        if (isQueryUsage(parent)) {
+          testingLibraryQueryUsage.push({ node: parent, queryName: node.name });
         }
       },
       'Program:exit'() {
-        testingLibraryQueryUsage.forEach(node => {
+        testingLibraryQueryUsage.forEach(({ node, queryName }) => {
           const variableDeclaratorParent = node.parent.parent;
 
           const references =
@@ -54,7 +62,7 @@ module.exports = {
               node,
               messageId: 'awaitAsyncQuery',
               data: {
-                name: node.name,
+                name: queryName,
               },
             });
           } else {
@@ -68,7 +76,7 @@ module.exports = {
                   node,
                   messageId: 'awaitAsyncQuery',
                   data: {
-                    name: node.name,
+                    name: queryName,
                   },
                 });
 

tests/lib/rules/await-async-query.js

@@ -151,6 +151,25 @@ ruleTester.run('await-async-query', rule, {
           },
         ],
       })),
+      ...ASYNC_QUERIES_COMBINATIONS.map(query => ({
+        code: `async () => {
+        screen.${query}('foo')
+      }
+      `,
+        errors: [
+          {
+            messageId: 'awaitAsyncQuery',
+          },
+        ],
+      })),
+      ...ASYNC_QUERIES_COMBINATIONS.map(query => ({
+        code: `const foo = screen.${query}('foo')`,
+        errors: [
+          {
+            messageId: 'awaitAsyncQuery',
+          },
+        ],
+      })),
       ...ASYNC_QUERIES_COMBINATIONS.map(query => ({
         code: `async () => {
         const foo = ${query}('foo')