Skip to content

Commit 0276efb

Browse files
committed
refactor: rename function to detect potential Testing Library func
1 parent fe7c394 commit 0276efb

File tree

1 file changed

+20
-16
lines changed

1 file changed

+20
-16
lines changed

lib/create-testing-library-rule/detect-testing-library-utils.ts

Lines changed: 20 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -172,9 +172,9 @@ export function detectTestingLibraryUtils<
172172
* - it's imported from valid Testing Library module (depends on aggressive
173173
* reporting)
174174
*/
175-
function isTestingLibraryUtil(
175+
function isPotentialTestingLibraryFunction(
176176
node: TSESTree.Identifier,
177-
isUtilCallback: (
177+
isPotentialFunctionCallback: (
178178
identifierNodeName: string,
179179
originalNodeName?: string
180180
) => boolean
@@ -200,7 +200,7 @@ export function detectTestingLibraryUtils<
200200
? importedUtilSpecifier.imported.name
201201
: undefined;
202202

203-
if (!isUtilCallback(node.name, originalNodeName)) {
203+
if (!isPotentialFunctionCallback(node.name, originalNodeName)) {
204204
return false;
205205
}
206206

@@ -412,7 +412,7 @@ export function detectTestingLibraryUtils<
412412
* coming from Testing Library will be considered as valid.
413413
*/
414414
const isAsyncUtil: IsAsyncUtilFn = (node, validNames = ASYNC_UTILS) => {
415-
return isTestingLibraryUtil(
415+
return isPotentialTestingLibraryFunction(
416416
node,
417417
(identifierNodeName, originalNodeName) => {
418418
return (
@@ -430,7 +430,7 @@ export function detectTestingLibraryUtils<
430430
* Not to be confused with {@link isFireEventMethod}
431431
*/
432432
const isFireEventUtil = (node: TSESTree.Identifier): boolean => {
433-
return isTestingLibraryUtil(
433+
return isPotentialTestingLibraryFunction(
434434
node,
435435
(identifierNodeName, originalNodeName) => {
436436
return [identifierNodeName, originalNodeName].includes('fireEvent');
@@ -570,17 +570,21 @@ export function detectTestingLibraryUtils<
570570
* only those nodes coming from Testing Library will be considered as valid.
571571
*/
572572
const isRenderUtil: IsRenderUtilFn = (node) =>
573-
isTestingLibraryUtil(node, (identifierNodeName, originalNodeName) => {
574-
if (isAggressiveRenderReportingEnabled()) {
575-
return identifierNodeName.toLowerCase().includes(RENDER_NAME);
576-
}
573+
isPotentialTestingLibraryFunction(
574+
node,
575+
(identifierNodeName, originalNodeName) => {
576+
if (isAggressiveRenderReportingEnabled()) {
577+
return identifierNodeName.toLowerCase().includes(RENDER_NAME);
578+
}
577579

578-
return [RENDER_NAME, ...getCustomRenders()].some(
579-
(validRenderName) =>
580-
validRenderName === identifierNodeName ||
581-
(Boolean(originalNodeName) && validRenderName === originalNodeName)
582-
);
583-
});
580+
return [RENDER_NAME, ...getCustomRenders()].some(
581+
(validRenderName) =>
582+
validRenderName === identifierNodeName ||
583+
(Boolean(originalNodeName) &&
584+
validRenderName === originalNodeName)
585+
);
586+
}
587+
);
584588

585589
const isRenderVariableDeclarator: IsRenderVariableDeclaratorFn = (node) => {
586590
if (!node.init) {
@@ -603,7 +607,7 @@ export function detectTestingLibraryUtils<
603607

604608
return (
605609
!isBuiltInConsole &&
606-
isTestingLibraryUtil(
610+
isPotentialTestingLibraryFunction(
607611
identifierNode,
608612
(identifierNodeName, originalNodeName) => {
609613
return [identifierNodeName, originalNodeName]

0 commit comments

Comments
 (0)