From c6e1bb958378fdfbac02a8e3fe7be7fa991c75bf Mon Sep 17 00:00:00 2001 From: Darek Kay Date: Sat, 20 Jun 2020 17:00:15 +0200 Subject: [PATCH] fix: Treat header as banner role The latest [aria-query version](https://github.com/A11yance/aria-query/releases/tag/v4.2.2) fixes the issue of failing to recognize `
` as a `banner` role. Fixes: #578 --- package.json | 2 +- src/__tests__/queries.find.js | 4 ++++ 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/package.json b/package.json index 18cc9185..eeb05783 100644 --- a/package.json +++ b/package.json @@ -39,7 +39,7 @@ ], "dependencies": { "@babel/runtime": "^7.10.2", - "aria-query": "^4.0.2", + "aria-query": "^4.2.1", "dom-accessibility-api": "^0.4.5", "pretty-format": "^25.5.0" }, diff --git a/src/__tests__/queries.find.js b/src/__tests__/queries.find.js index d3d59832..f8c48f1f 100644 --- a/src/__tests__/queries.find.js +++ b/src/__tests__/queries.find.js @@ -34,6 +34,7 @@ test('find asynchronously finds elements', async () => {
+
header
`) await expect(findByLabelText('test-label')).resolves.toBeTruthy() @@ -66,6 +67,9 @@ test('find asynchronously finds elements', async () => { findAllByRole('progressbar', {queryFallbacks: true}), ).resolves.toHaveLength(1) + await expect(findByRole('banner')).resolves.toBeTruthy() + await expect(findAllByRole('banner')).resolves.toHaveLength(1) + await expect(findByTestId('test-id')).resolves.toBeTruthy() await expect(findAllByTestId('test-id')).resolves.toHaveLength(1) })