From 6d810ddd870c20675cbdee7a0179ec92ca4e414a Mon Sep 17 00:00:00 2001 From: Naor Peled Date: Sat, 12 Aug 2023 16:03:56 +0300 Subject: [PATCH 1/2] feat(role-helpers): refine logRoles fn types --- types/role-helpers.d.ts | 12 +++++++++++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/types/role-helpers.d.ts b/types/role-helpers.d.ts index 0b5b9124..95c64bdc 100644 --- a/types/role-helpers.d.ts +++ b/types/role-helpers.d.ts @@ -1,9 +1,19 @@ -export function logRoles(container: HTMLElement): string +export function logRoles( + container: HTMLElement, + options?: LogRolesOptions, +): string + +type LogRolesOptions = { + hidden?: boolean +} + export function getRoles(container: HTMLElement): { [index: string]: HTMLElement[] } + /** * https://testing-library.com/docs/dom-testing-library/api-helpers#isinaccessible */ export function isInaccessible(element: Element): boolean + export function computeHeadingLevel(element: Element): number | undefined From adfea2983891aac3ab70dbd305b7d252663dce86 Mon Sep 17 00:00:00 2001 From: Naor Peled Date: Sat, 12 Aug 2023 16:08:27 +0300 Subject: [PATCH 2/2] fix(role-helpers.d.ts): CR - use interface --- types/role-helpers.d.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/types/role-helpers.d.ts b/types/role-helpers.d.ts index 95c64bdc..fe14c13a 100644 --- a/types/role-helpers.d.ts +++ b/types/role-helpers.d.ts @@ -3,7 +3,7 @@ export function logRoles( options?: LogRolesOptions, ): string -type LogRolesOptions = { +interface LogRolesOptions { hidden?: boolean }