fix: lint

Author: DaniAcu

src/queries/role.ts

@@ -124,13 +124,13 @@ const queryAllByRole: AllByRole = (
     }
   }
 
-  const subtreeIsInaccessibleCache = new WeakMap()
-  function cachedIsSubtreeInaccessible(element: Element) {
+  const subtreeIsInaccessibleCache = new WeakMap<HTMLElement, Boolean>()
+  function cachedIsSubtreeInaccessible(element: HTMLElement): Boolean {
     if (!subtreeIsInaccessibleCache.has(element)) {
       subtreeIsInaccessibleCache.set(element, isSubtreeInaccessible(element))
     }
 
-    return subtreeIsInaccessibleCache.get(element)
+    return subtreeIsInaccessibleCache.get(element) as Boolean
   }
 
   return Array.from(
@@ -143,7 +143,7 @@ const queryAllByRole: AllByRole = (
       const isRoleSpecifiedExplicitly = node.hasAttribute('role')
 
       if (isRoleSpecifiedExplicitly) {
-        const roleValue = node.getAttribute('role')!
+        const roleValue = node.getAttribute('role') as string
         if (queryFallbacks) {
           return roleValue
             .split(' ')
@@ -222,7 +222,7 @@ const queryAllByRole: AllByRole = (
     .filter(element => {
       return hidden === false
         ? isInaccessible(element, {
-            isSubtreeInaccessible: cachedIsSubtreeInaccessible,
+            isSubtreeInaccessible: cachedIsSubtreeInaccessible as any,
           }) === false
         : true
     })
@@ -241,7 +241,7 @@ function makeRoleSelector(
   const explicitRoleSelector =
     exact && !customNormalizer ? `*[role~="${role}"]` : '*[role]'
 
-  const roleRelations = roleElements.get(role as any) ?? new Set()
+  const roleRelations = roleElements.get(role) ?? new Set()
   const implicitRoleSelectors = new Set(
     Array.from(roleRelations).map(({name}) => name),
   )
@@ -285,7 +285,7 @@ const getMissingError: GetErrorFunction<
   }
 
   let roles = ''
-  Array.from(container!.children).forEach(childElement => {
+  Array.from((container as Element).children).forEach(childElement => {
     roles += prettyRoles(childElement, {
       hidden,
       includeDescription: description !== undefined,

src/query-helpers.ts

@@ -213,16 +213,15 @@ const wrapAllByQueryWithSuggestion =
 // However, the implementation always required a dyadic (after `container`) not variadic `queryAllBy` considering the implementation of `makeFindQuery`
 // This is at least statically true and can be verified by accepting `QueryMethod<Arguments, HTMLElement[]>`
 function buildQueries(
-  queryAllBy: QueryMethod<
-    [matcher: Matcher, options: MatcherOptions],
-    HTMLElement[]
-  >,
-  getMultipleError: GetErrorFunction<
-    [matcher: Matcher, options: MatcherOptions]
-  >,
-  getMissingError: GetErrorFunction<
-    [matcher: Matcher, options: MatcherOptions]
-  >,
+  queryAllBy:
+    | AllByRole
+    | QueryMethod<[matcher: Matcher, options: MatcherOptions], HTMLElement[]>,
+  getMultipleError:
+    | GetErrorFunction<[matcher: ByRoleMatcher, options: ByRoleOptions]>
+    | GetErrorFunction<[matcher: Matcher, options: MatcherOptions]>,
+  getMissingError:
+    | GetErrorFunction<[matcher: ByRoleMatcher, options: ByRoleOptions]>
+    | GetErrorFunction<[matcher: Matcher, options: MatcherOptions]>,
 ) {
   const queryBy = wrapSingleQueryWithSuggestion(
     makeSingleQuery(queryAllBy, getMultipleError),
@@ -244,9 +243,11 @@ function buildQueries(
   )
 
   const findAllBy = makeFindQuery(
+    /* @ts-ignore */
     wrapAllByQueryWithSuggestion(getAllBy, queryAllBy.name, 'findAll'),
   )
   const findBy = makeFindQuery(
+    /* @ts-ignore */
     wrapSingleQueryWithSuggestion(getBy, queryAllBy.name, 'find'),
   )
 

types/matches.d.ts

@@ -8,7 +8,7 @@ export type Matcher = MatcherFunction | RegExp | number | string
 
 // Get autocomplete for ARIARole union types, while still supporting another string
 // Ref: https://github.com/microsoft/TypeScript/issues/29729#issuecomment-505826972
-export type ByRoleMatcher = ARIARole | MatcherFunction | {}
+export type ByRoleMatcher = ARIARole | MatcherFunction
 
 export type NormalizerFn = (text: string) => string