Merge branch 'master' into 372-label-fix

Author: Kent C. Dodds

.all-contributorsrc

@@ -633,7 +633,8 @@
       "contributions": [
         "code",
         "test",
-        "doc"
+        "doc",
+        "infra"
       ]
     },
     {
@@ -721,7 +722,8 @@
       "profile": "http://olzhas.de",
       "contributions": [
         "code",
-        "test"
+        "test",
+        "doc"
       ]
     },
     {
@@ -733,6 +735,24 @@
         "code",
         "test"
       ]
+    },
+    {
+      "login": "mmantel",
+      "name": "Michael Mantel",
+      "avatar_url": "https://avatars2.githubusercontent.com/u/1326403?v=4",
+      "profile": "https://github.com/mmantel",
+      "contributions": [
+        "test"
+      ]
+    },
+    {
+      "login": "tomanagle",
+      "name": "Tom Nagle",
+      "avatar_url": "https://avatars1.githubusercontent.com/u/8683577?v=4",
+      "profile": "https://tomdoes.tech/",
+      "contributions": [
+        "code"
+      ]
     }
   ],
   "repoHost": "https://github.com"

.codesandbox/ci.json

@@ -0,0 +1,3 @@
+{
+  "sandboxes": ["github/kentcdodds/react-testing-library-examples"]
+}

.github/ISSUE_TEMPLATE.md

@@ -8,11 +8,11 @@ understand what's going on and fix the issue.
 
 I'll probably ask you to submit the fix (after giving some direction). If you've
 never done that before, that's great! Check this free short video tutorial to
-learn how: http://kcd.im/pull-request
+learn how: https://kcd.im/pull-request
 
 
 If this is an issue with the documentation, please file an issue in the docs repo:
-https://github.com/alexkrolick/testing-library-docs
+https://github.com/testing-library/testing-library-docs
 
 -->
 
@@ -22,7 +22,7 @@ https://github.com/alexkrolick/testing-library-docs
 
 Relevant code or config
 
-```javascript
+```js
 ```
 
 What you did:
@@ -32,7 +32,7 @@ What happened:
 <!-- Please provide the full error message/screenshots/anything -->
 
 Reproduction repository:
-https://github.com/alexkrolick/dom-testing-library-template
+https://github.com/testing-library/dom-testing-library-template
 
 <!--
 If possible, please create a repository that reproduces the issue with the

.github/ISSUE_TEMPLATE/Bug_Report.md

@@ -14,7 +14,7 @@ about: Bugs, missing documentation, or unexpected behavior 🤔.
 
 We'll probably ask you to submit the fix (after giving some direction). If
 you've never done that before, that's great! Check this free short video
-tutorial to learn how: http://kcd.im/pull-request
+tutorial to learn how: https://kcd.im/pull-request
 
 If this is an issue with the documentation, please file an issue in the docs repo:
 https://github.com/testing-library/testing-library-docs

.github/ISSUE_TEMPLATE/Feature_Request.md

@@ -17,11 +17,11 @@ to work on.
 
 It'd be great if after the discussion you're the one who submits the PR that
 implements this feature. If you've never done that before, that's great! Check
-this free short video tutorial to learn how: http://kcd.im/pull-request
+this free short video tutorial to learn how: https://kcd.im/pull-request
 
 
 If this is an issue with the documentation, please file an issue in the docs repo:
-https://github.com/alexkrolick/testing-library-docs
+https://github.com/testing-library/testing-library-docs
 -->
 
 ### Describe the feature you'd like:

.github/PULL_REQUEST_TEMPLATE.md

@@ -8,7 +8,7 @@ Also, please make sure you're familiar with and follow the instructions in the
 contributing guidelines (found in the CONTRIBUTING.md file).
 
 If you're new to contributing to open source projects, you might find this free
-video course helpful: http://kcd.im/pull-request
+video course helpful: https://kcd.im/pull-request
 
 Please fill out the information below to expedite the review and (hopefully)
 merge of your pull request!
@@ -35,8 +35,9 @@ merge of your pull request!
 <!-- to check an item, place an "x" in the box like so: "- [x] Documentation" -->
 
 - [ ] Documentation added to the
-      [docs site](https://github.com/alexkrolick/testing-library-docs)
-- [ ] I've prepared a PR for types targetting https://github.com/DefinitelyTyped/DefinitelyTyped/tree/master/types/testing-library__dom
+      [docs site](https://github.com/testing-library/testing-library-docs)
+- [ ] I've prepared a PR for types targeting
+      [DefinitelyTyped](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/master/types/testing-library__dom)
 - [ ] Tests
 - [ ] Ready to be merged
       <!-- In your opinion, is this ready to be merged as soon as it's reviewed? -->

CODE_OF_CONDUCT.md

@@ -69,7 +69,8 @@ members of the project's leadership.
 ## Attribution
 
 This Code of Conduct is adapted from the [Contributor Covenant][homepage],
-version 1.4, available at [http://contributor-covenant.org/version/1/4][version]
+version 1.4, available at
+[https://contributor-covenant.org/version/1/4][version]
 
-[homepage]: http://contributor-covenant.org
-[version]: http://contributor-covenant.org/version/1/4/
+[homepage]: https://contributor-covenant.org
+[version]: https://contributor-covenant.org/version/1/4/

README.md

@@ -27,7 +27,7 @@ practices.</p>
 [![downloads][downloads-badge]][npmtrends]
 [![MIT License][license-badge]][license]
 
-[![All Contributors](https://img.shields.io/badge/all_contributors-74-orange.svg?style=flat-square)](#contributors)
+[![All Contributors](https://img.shields.io/badge/all_contributors-76-orange.svg?style=flat-square)](#contributors)
 [![PRs Welcome][prs-badge]][prs]
 [![Code of Conduct][coc-badge]][coc]
 
@@ -212,7 +212,7 @@ Thanks goes to these people ([emoji key][emojis]):
     <td align="center"><a href="https://github.com/michaellasky"><img src="https://avatars2.githubusercontent.com/u/6646599?v=4" width="100px;" alt="Michael Lasky"/><br /><sub><b>Michael Lasky</b></sub></a><br /><a href="https://github.com/testing-library/dom-testing-library/commits?author=michaellasky" title="Code">💻</a> <a href="https://github.com/testing-library/dom-testing-library/commits?author=michaellasky" title="Tests">⚠️</a> <a href="https://github.com/testing-library/dom-testing-library/commits?author=michaellasky" title="Documentation">📖</a></td>
   </tr>
   <tr>
-    <td align="center"><a href="https://twitter.com/sebsilbermann"><img src="https://avatars3.githubusercontent.com/u/12292047?v=4" width="100px;" alt="Sebastian Silbermann"/><br /><sub><b>Sebastian Silbermann</b></sub></a><br /><a href="https://github.com/testing-library/dom-testing-library/commits?author=eps1lon" title="Code">💻</a> <a href="https://github.com/testing-library/dom-testing-library/commits?author=eps1lon" title="Tests">⚠️</a> <a href="https://github.com/testing-library/dom-testing-library/commits?author=eps1lon" title="Documentation">📖</a></td>
+    <td align="center"><a href="https://twitter.com/sebsilbermann"><img src="https://avatars3.githubusercontent.com/u/12292047?v=4" width="100px;" alt="Sebastian Silbermann"/><br /><sub><b>Sebastian Silbermann</b></sub></a><br /><a href="https://github.com/testing-library/dom-testing-library/commits?author=eps1lon" title="Code">💻</a> <a href="https://github.com/testing-library/dom-testing-library/commits?author=eps1lon" title="Tests">⚠️</a> <a href="https://github.com/testing-library/dom-testing-library/commits?author=eps1lon" title="Documentation">📖</a> <a href="#infra-eps1lon" title="Infrastructure (Hosting, Build-Tools, etc)">🚇</a></td>
     <td align="center"><a href="https://dylanvann.com/"><img src="https://avatars0.githubusercontent.com/u/1537615?v=4" width="100px;" alt="Dylan Vann"/><br /><sub><b>Dylan Vann</b></sub></a><br /><a href="https://github.com/testing-library/dom-testing-library/commits?author=DylanVann" title="Code">💻</a></td>
     <td align="center"><a href="https://afontcu.dev"><img src="https://avatars0.githubusercontent.com/u/9197791?v=4" width="100px;" alt="Adrià Fontcuberta"/><br /><sub><b>Adrià Fontcuberta</b></sub></a><br /><a href="https://github.com/testing-library/dom-testing-library/commits?author=afontcu" title="Code">💻</a> <a href="https://github.com/testing-library/dom-testing-library/commits?author=afontcu" title="Tests">⚠️</a> <a href="https://github.com/testing-library/dom-testing-library/commits?author=afontcu" title="Documentation">📖</a></td>
     <td align="center"><a href="http://thomlom.dev"><img src="https://avatars3.githubusercontent.com/u/16003285?v=4" width="100px;" alt="Thomas Lombart"/><br /><sub><b>Thomas Lombart</b></sub></a><br /><a href="https://github.com/testing-library/dom-testing-library/commits?author=thomlom" title="Code">💻</a></td>
@@ -223,8 +223,10 @@ Thanks goes to these people ([emoji key][emojis]):
   <tr>
     <td align="center"><a href="https://github.com/brapifra"><img src="https://avatars3.githubusercontent.com/u/17855450?v=4" width="100px;" alt="Brais Piñeiro"/><br /><sub><b>Brais Piñeiro</b></sub></a><br /><a href="https://github.com/testing-library/dom-testing-library/commits?author=brapifra" title="Code">💻</a> <a href="https://github.com/testing-library/dom-testing-library/commits?author=brapifra" title="Tests">⚠️</a></td>
     <td align="center"><a href="https://www.dominykas.com/"><img src="https://avatars1.githubusercontent.com/u/505619?v=4" width="100px;" alt="Dominykas Blyžė"/><br /><sub><b>Dominykas Blyžė</b></sub></a><br /><a href="https://github.com/testing-library/dom-testing-library/commits?author=dominykas" title="Code">💻</a> <a href="https://github.com/testing-library/dom-testing-library/commits?author=dominykas" title="Tests">⚠️</a></td>
-    <td align="center"><a href="http://olzhas.de"><img src="https://avatars3.githubusercontent.com/u/15848876?v=4" width="100px;" alt="Olzhas Askar"/><br /><sub><b>Olzhas Askar</b></sub></a><br /><a href="https://github.com/testing-library/dom-testing-library/commits?author=pheeria" title="Code">💻</a> <a href="https://github.com/testing-library/dom-testing-library/commits?author=pheeria" title="Tests">⚠️</a></td>
+    <td align="center"><a href="http://olzhas.de"><img src="https://avatars3.githubusercontent.com/u/15848876?v=4" width="100px;" alt="Olzhas Askar"/><br /><sub><b>Olzhas Askar</b></sub></a><br /><a href="https://github.com/testing-library/dom-testing-library/commits?author=pheeria" title="Code">💻</a> <a href="https://github.com/testing-library/dom-testing-library/commits?author=pheeria" title="Tests">⚠️</a> <a href="https://github.com/testing-library/dom-testing-library/commits?author=pheeria" title="Documentation">📖</a></td>
     <td align="center"><a href="https://twitter.com/mbelsky_"><img src="https://avatars1.githubusercontent.com/u/3923527?v=4" width="100px;" alt="Max Belsky"/><br /><sub><b>Max Belsky</b></sub></a><br /><a href="https://github.com/testing-library/dom-testing-library/commits?author=mbelsky" title="Code">💻</a> <a href="https://github.com/testing-library/dom-testing-library/commits?author=mbelsky" title="Tests">⚠️</a></td>
+    <td align="center"><a href="https://github.com/mmantel"><img src="https://avatars2.githubusercontent.com/u/1326403?v=4" width="100px;" alt="Michael Mantel"/><br /><sub><b>Michael Mantel</b></sub></a><br /><a href="https://github.com/testing-library/dom-testing-library/commits?author=mmantel" title="Tests">⚠️</a></td>
+    <td align="center"><a href="https://tomdoes.tech/"><img src="https://avatars1.githubusercontent.com/u/8683577?v=4" width="100px;" alt="Tom Nagle"/><br /><sub><b>Tom Nagle</b></sub></a><br /><a href="https://github.com/testing-library/dom-testing-library/commits?author=tomanagle" title="Code">💻</a></td>
   </tr>
 </table>
 

other/testingjavascript.jpg

@@ -17,7 +17,7 @@
     "end-to-end",
     "e2e"
   ],
-  "author": "Kent C. Dodds <kent@doddsfamily.us> (http://kentcdodds.com/)",
+  "author": "Kent C. Dodds <kent@doddsfamily.us> (https://kentcdodds.com/)",
   "license": "MIT",
   "engines": {
     "node": ">=8"
@@ -40,20 +40,20 @@
     "dist"
   ],
   "dependencies": {
-    "@babel/runtime": "^7.5.5",
+    "@babel/runtime": "^7.6.2",
     "@sheerun/mutationobserver-shim": "^0.3.2",
     "@types/testing-library__dom": "^6.0.0",
     "aria-query": "3.0.0",
-    "pretty-format": "^24.8.0",
-    "wait-for-expect": "^1.3.0"
+    "pretty-format": "^24.9.0",
+    "wait-for-expect": "^3.0.0"
   },
   "devDependencies": {
-    "@testing-library/jest-dom": "^4.0.0",
+    "@testing-library/jest-dom": "^4.1.0",
     "jest-in-case": "^1.0.2",
     "jest-serializer-ansi": "^1.0.3",
-    "jest-watch-select-projects": "^0.1.1",
+    "jest-watch-select-projects": "^1.0.0",
     "jsdom": "^15.1.1",
-    "kcd-scripts": "^1.5.2"
+    "kcd-scripts": "^1.7.0"
   },
   "eslintConfig": {
     "extends": "./node_modules/kcd-scripts/eslint.js",

package.json

@@ -76,3 +76,23 @@ test('works without a browser context on a dom node (JSDOM Fragment)', () => {
     />
   `)
 })
+
+test('byRole works without a global DOM', () => {
+  const {
+    window: {
+      document: {body: container},
+    },
+  } = new JSDOM(`
+    <html>
+      <body>
+        <button>Say "Hello, Dave!"</button>
+      </body>
+    </html>
+  `)
+
+  expect(dtl.getByRole(container, 'button')).toMatchInlineSnapshot(`
+    <button>
+      Say "Hello, Dave!"
+    </button>
+  `)
+})

src/__node_tests__/index.js

@@ -0,0 +1,9 @@
+import {screen} from '..'
+
+test('the screen export throws a helpful error message when no global document is accessible', () => {
+  expect(() =>
+    screen.getByText(/hello world/i),
+  ).toThrowErrorMatchingInlineSnapshot(
+    `"For queries bound to document.body a global document has to be available... Learn more: https://testing-library.com/s/screen-global-error"`,
+  )
+})

src/__node_tests__/screen.js

@@ -414,6 +414,12 @@ test('query/get select by text with multiple options selected', () => {
 })
 
 describe('query by test id', () => {
+  afterEach(() => {
+    // Restore the default test id attribute
+    // even if these tests failed
+    configure({testIdAttribute: 'data-testid'})
+  })
+
   test('can get elements by test id', () => {
     const {queryByTestId} = render(`<div data-testid="firstName"></div>`)
     expect(queryByTestId('firstName')).toBeTruthy()
@@ -435,12 +441,6 @@ describe('query by test id', () => {
     configure({testIdAttribute: 'something-else'})
     expect(queryByTestId('theTestId')).toBeFalsy()
   })
-
-  afterEach(() => {
-    // Restore the default test id attribute
-    // even if these tests failed
-    configure({testIdAttribute: 'data-testid'})
-  })
 })
 
 test('queryAllByRole returns semantic html elements', () => {