Skip to content

Commit 7a53e33

Browse files
committed
remove includeName option
1 parent 3fcf430 commit 7a53e33

File tree

2 files changed

+7
-6
lines changed

2 files changed

+7
-6
lines changed

src/__tests__/role.js

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,7 @@ Here are the accessible roles:
1111
1212
heading:
1313
14+
Name "Hi":
1415
<h1 />
1516
1617
--------------------------------------------------
@@ -33,6 +34,7 @@ Here are the available roles:
3334
3435
heading:
3536
37+
Name "Hi":
3638
<h1 />
3739
3840
--------------------------------------------------
@@ -227,7 +229,7 @@ test('can be filtered by accessible name', () => {
227229
test('accessible name comparison is case sensitive', () => {
228230
const {getByRole} = render(`<h1>Sign <em>up</em></h1>`)
229231

230-
// actual: "Sign up",
232+
// actual: "Sign up",
231233
// queried: "Sign Up"
232234
expect(() => getByRole('heading', {name: 'Sign Up'}))
233235
.toThrowErrorMatchingInlineSnapshot(`

src/role-helpers.js

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -139,16 +139,15 @@ function getRoles(container, {hidden = false} = {}) {
139139
}, {})
140140
}
141141

142-
function prettyRoles(dom, {hidden, includeName}) {
142+
function prettyRoles(dom, {hidden}) {
143143
const roles = getRoles(dom, {hidden})
144144

145145
return Object.entries(roles)
146146
.map(([role, elements]) => {
147147
const delimiterBar = '-'.repeat(50)
148148
const elementsString = elements
149149
.map(el => {
150-
const nameString =
151-
includeName === true ? `Name "${computeAccessibleName(el)}":\n` : ''
150+
const nameString = `Name "${computeAccessibleName(el)}":\n`
152151
const domString = prettyDOM(el.cloneNode(false))
153152
return `${nameString}${domString}`
154153
})
@@ -159,8 +158,8 @@ function prettyRoles(dom, {hidden, includeName}) {
159158
.join('\n')
160159
}
161160

162-
const logRoles = (dom, {hidden = false, includeName = true} = {}) =>
163-
console.log(prettyRoles(dom, {hidden, includeName}))
161+
const logRoles = (dom, {hidden = false} = {}) =>
162+
console.log(prettyRoles(dom, {hidden}))
164163

165164
export {
166165
getRoles,

0 commit comments

Comments
 (0)