fix: getByTitle returning element matching textContent instead of title (#753)

Co-authored-by: Kent C. Dodds <me+github@kentcdodds.com>

Closes #741

Author: wyze

src/__tests__/element-queries.js

@@ -551,12 +551,14 @@ test('query/get element by its title', () => {
         <span title="Ignore this" id="1"/>
         <span title="Delete" id="2"/>
         <span title="Ignore this as well" id="3"/>
+        <div title="WrongTitle" id="4">HelloWorld</div>
     </div>
   `)
 
   expect(getByTitle('Delete').id).toEqual('2')
   expect(queryByTitle('Delete').id).toEqual('2')
   expect(queryByTitle('Del', {exact: false}).id).toEqual('2')
+  expect(queryByTitle("HelloWorld")).toBeNull()
 })
 
 test('query/get title element of SVG', () => {

src/queries/title.js

@@ -8,6 +8,10 @@ import {
   buildQueries,
 } from './all-utils'
 
+const isSvgTitle = node =>
+  node.tagName.toLowerCase() === 'title' &&
+  node.parentElement?.tagName.toLowerCase() === 'svg'
+
 function queryAllByTitle(
   container,
   text,
@@ -19,7 +23,8 @@ function queryAllByTitle(
   return Array.from(container.querySelectorAll('[title], svg > title')).filter(
     node =>
       matcher(node.getAttribute('title'), node, text, matchNormalizer) ||
-      matcher(getNodeText(node), node, text, matchNormalizer),
+      (isSvgTitle(node) &&
+        matcher(getNodeText(node), node, text, matchNormalizer)),
   )
 }