chore: modernize things (lint TS)

Author: kentcdodds

package.json

@@ -48,14 +48,14 @@
     "pretty-format": "^26.6.2"
   },
   "devDependencies": {
-    "@testing-library/jest-dom": "^5.11.5",
+    "@testing-library/jest-dom": "^5.11.6",
     "@types/estree": "0.0.45",
     "dtslint": "^4.0.5",
     "jest-in-case": "^1.0.2",
     "jest-serializer-ansi": "^1.0.3",
     "jest-watch-select-projects": "^2.0.0",
     "jsdom": "^16.4.0",
-    "kcd-scripts": "^6.7.0",
+    "kcd-scripts": "^7.0.3",
     "typescript": "^4.0.5"
   },
   "eslintConfig": {

src/__tests__/suggestions.js

@@ -552,6 +552,8 @@ test('should get the first label with aria-labelledby contains multiple ids', ()
 })
 
 test('should suggest hidden option if element is not in the accessibilty tree', () => {
+  console.warn.mockImplementation(() => {})
+
   const {container} = renderIntoDocument(`
     <input type="text" aria-hidden=true />
   `)

types/.eslintrc

@@ -0,0 +1,6 @@
+{
+  "rules": {
+    "one-var": "off",
+    "@typescript-eslint/no-explicit-any": "off" // let's do better in the future
+  }
+}

types/__tests__/type-tests.ts

@@ -23,7 +23,7 @@ const {
   findByRole,
 } = queries
 
-async function testQueries() {
+export async function testQueries() {
   // element queries
   const element = document.createElement('div')
   getByText(element, 'foo')
@@ -46,7 +46,7 @@ async function testQueries() {
   await screen.findAllByText('bar', undefined, {timeout: 10})
 }
 
-async function testQueryHelpers() {
+export async function testQueryHelpers() {
   const element = document.createElement('div')
   const includesAutomationId = (content: string, automationId: string) =>
     content.split(/\s+/).some(id => id === automationId)
@@ -78,16 +78,16 @@ async function testQueryHelpers() {
   queryByAutomationId(element, 'id')
   getAllByAutomationId(element, 'id')
   getByAutomationId(element, ['id', 'automationId'])
-  findAllByAutomationId(element, 'id', {}, {timeout: 1000})
-  findByAutomationId(element, 'id', {}, {timeout: 1000})
+  await findAllByAutomationId(element, 'id', {}, {timeout: 1000})
+  await findByAutomationId(element, 'id', {}, {timeout: 1000})
   // test optional params too
-  findAllByAutomationId(element, 'id', {})
-  findByAutomationId(element, 'id', {})
-  findAllByAutomationId(element, 'id')
-  findByAutomationId(element, 'id')
+  await findAllByAutomationId(element, 'id', {})
+  await findByAutomationId(element, 'id', {})
+  await findAllByAutomationId(element, 'id')
+  await findByAutomationId(element, 'id')
 }
 
-async function testByRole() {
+export async function testByRole() {
   const element = document.createElement('button')
   element.setAttribute('aria-hidden', 'true')
 
@@ -115,8 +115,7 @@ async function testByRole() {
   console.assert(queryByRole(element, 'button', {name: /^Log/}) === null)
   console.assert(
     queryByRole(element, 'button', {
-      name: (name, element) =>
-        name === 'Login' && element.hasAttribute('disabled'),
+      name: (name, el) => name === 'Login' && el.hasAttribute('disabled'),
     }) === null,
   )
 
@@ -127,12 +126,12 @@ async function testByRole() {
   console.assert(screen.queryByRole(/foo/) === null)
 }
 
-function testA11yHelper() {
+export function testA11yHelper() {
   const element = document.createElement('svg')
   console.assert(!isInaccessible(element))
 }
 
-function eventTest() {
+export function eventTest() {
   fireEvent.popState(window, {
     location: 'http://www.example.com/?page=1',
     state: {page: 1},
@@ -156,7 +155,7 @@ function eventTest() {
   fireEvent(element, customEvent)
 }
 
-async function testWaitFors() {
+export async function testWaitFors() {
   const element = document.createElement('div')
 
   await waitFor(() => getByText(element, 'apple'))
@@ -181,3 +180,8 @@ async function testWaitFors() {
 
   await waitFor(async () => {})
 }
+
+/*
+eslint
+  @typescript-eslint/no-unnecessary-condition: "off",
+*/

types/screen.d.ts

@@ -1,6 +1,6 @@
+import {OptionsReceived} from 'pretty-format'
 import {BoundFunctions, Queries} from './get-queries-for-element'
 import * as queries from './queries'
-import {OptionsReceived} from 'pretty-format'
 
 export type Screen<Q extends Queries = typeof queries> = BoundFunctions<Q> & {
   /**