Skip to content

Commit c229778

Browse files
feat: remove detectChanges in favor of detectChangesOnRender (#341)
BREAKING CHANGE: The config property detectChanges is renamed to detectChangesOnRender. BEFORE: ```ts const component = await render(AppComponent, { detectChanges: false }); ``` AFTER: ```ts const component = await render(AppComponent, { detectChangesOnRender: false }); ```
1 parent 40342b6 commit c229778

File tree

2 files changed

+1
-21
lines changed

2 files changed

+1
-21
lines changed

projects/testing-library/src/lib/models.ts

Lines changed: 0 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -89,22 +89,6 @@ export interface RenderComponentOptions<ComponentType, Q extends Queries = typeo
8989
* })
9090
*/
9191
autoDetectChanges?: boolean;
92-
/**
93-
* @description
94-
* Will call detectChanges when the component is compiled
95-
*
96-
* @default
97-
* true
98-
*
99-
* @example
100-
* const component = await render(AppComponent, {
101-
* detectChanges: false
102-
* })
103-
*
104-
* @deprecated
105-
* Use `detectChangesOnRender` instead
106-
*/
107-
detectChanges?: boolean;
10892
/**
10993
* @description
11094
* Invokes `detectChanges` after the component is rendered

projects/testing-library/src/lib/testing-library.ts

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -46,8 +46,7 @@ export async function render<SutType, WrapperType = SutType>(
4646
): Promise<RenderResult<SutType>> {
4747
const { dom: domConfig, ...globalConfig } = getConfig();
4848
const {
49-
detectChanges: detectChangesDeprecated = true,
50-
detectChangesOnRender: detectChangesOnRenderInput,
49+
detectChangesOnRender = true,
5150
autoDetectChanges = true,
5251
declarations = [],
5352
imports = [],
@@ -67,9 +66,6 @@ export async function render<SutType, WrapperType = SutType>(
6766
defaultImports = [],
6867
} = { ...globalConfig, ...renderOptions };
6968

70-
const detectChangesOnRender =
71-
detectChangesOnRenderInput === undefined ? detectChangesDeprecated : detectChangesOnRenderInput;
72-
7369
dtlConfigure(domConfig);
7470

7571
TestBed.configureTestingModule({

0 commit comments

Comments
 (0)