Skip to content

feat!: Add support for user_data_replace_on_change, and updated AWS provider to v4.7+ #272

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
May 9, 2022
Merged

feat!: Add support for user_data_replace_on_change, and updated AWS provider to v4.7+ #272

merged 6 commits into from
May 9, 2022

Conversation

brad-alexander
Copy link
Contributor

Description

Add support for user_data_replace_on_change attribute

Motivation and Context

Update to match aws provider feature

Breaking Changes

I don't believe so, it only adds a bool var with default set to aws provider default.

How Has This Been Tested?

  • I have updated at least one of the examples/* to demonstrate and validate my change(s)
  • I have tested and validated these changes using one or more of the provided examples/* projects
  • I have executed pre-commit run -a on my pull request

@brad-alexander brad-alexander changed the title Add support for user_data_replace_on_change feat: Add support for user_data_replace_on_change May 6, 2022
antonbabenko
antonbabenko requested changes May 6, 2022
View reviewed changes
Copy link
Member

@antonbabenko antonbabenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update versions.tf to use AWS provider 4.7 as the minimum requirement in root module and in the examples. This PR will produce a major release.

@antonbabenko antonbabenko changed the title feat: Add support for user_data_replace_on_change feat!: Add support for user_data_replace_on_change, and updated AWS provider to v4.7+ May 6, 2022
antonbabenko
antonbabenko approved these changes May 7, 2022
View reviewed changes
Copy link
Member

@antonbabenko antonbabenko left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you fix the failed checks (run pre-commit run -a and commit the changes locally) and I will merge this?

I have fixed it for you. :)

@antonbabenko antonbabenko merged commit 4d7f3d8 into terraform-aws-modules:master May 9, 2022
antonbabenko pushed a commit that referenced this pull request May 9, 2022
@semantic-release-bot
chore(release): version 4.0.0 [skip ci]
9aa189f 
## [4.0.0](v3.6.0...v4.0.0) (2022-05-09)

### ⚠ BREAKING CHANGES

* Add support for user_data_replace_on_change, and updated AWS provider to v4.7+ (#272)

### Features

* Add support for user_data_replace_on_change, and updated AWS provider to v4.7+ ([#272](#272)) ([4d7f3d8](4d7f3d8))
@antonbabenko
Copy link
Member

This PR is included in version 4.0.0 🎉

@brad-alexander
Copy link
Contributor Author

I have fixed it for you. :)

Thank you! I appreciate all the help on this 🙏

@github-actions
Copy link

github-actions bot commented Nov 8, 2022

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@antonbabenko antonbabenko antonbabenko approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@brad-alexander @antonbabenko