Skip to content

Commit 6d79740

Browse files
authored
pr6394
pr6394
2 parents 6200e1a + 7f40b32 commit 6d79740

File tree

1 file changed

+17
-7
lines changed

1 file changed

+17
-7
lines changed

cores/esp32/HardwareSerial.cpp

Lines changed: 17 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@ void serialEvent(void) {}
3737
#ifndef RX1
3838
#if CONFIG_IDF_TARGET_ESP32
3939
#define RX1 9
40-
#elif CONFIG_IDF_TARGET_ESP32S2
40+
#elif CONFIG_IDF_TARGET_ESP32S2
4141
#define RX1 18
4242
#elif CONFIG_IDF_TARGET_ESP32C3
4343
#define RX1 18
@@ -86,6 +86,8 @@ void serialEvent2(void) {}
8686
#if !defined(NO_GLOBAL_INSTANCES) && !defined(NO_GLOBAL_SERIAL)
8787
#if ARDUINO_USB_CDC_ON_BOOT //Serial used for USB CDC
8888
HardwareSerial Serial0(0);
89+
#elif ARDUINO_HW_CDC_ON_BOOT
90+
HardwareSerial Serial0(0);
8991
#else
9092
HardwareSerial Serial(0);
9193
#endif
@@ -100,6 +102,8 @@ void serialEventRun(void)
100102
{
101103
#if ARDUINO_USB_CDC_ON_BOOT //Serial used for USB CDC
102104
if(Serial0.available()) serialEvent();
105+
#elif ARDUINO_HW_CDC_ON_BOOT
106+
if(Serial0.available()) serialEvent();
103107
#else
104108
if(Serial.available()) serialEvent();
105109
#endif
@@ -257,19 +261,25 @@ void HardwareSerial::begin(unsigned long baud, uint32_t config, int8_t rxPin, in
257261
if (!uartIsDriverInstalled(_uart)) {
258262
switch (_uart_nr) {
259263
case UART_NUM_0:
260-
rxPin = rxPin < 0 ? SOC_RX0 : rxPin;
261-
txPin = txPin < 0 ? SOC_TX0 : txPin;
264+
if (rxPin < 0 && txPin < 0) {
265+
rxPin = SOC_RX0;
266+
txPin = SOC_TX0;
267+
}
262268
break;
263269
#if SOC_UART_NUM > 1 // may save some flash bytes...
264270
case UART_NUM_1:
265-
rxPin = rxPin < 0 ? RX1 : rxPin;
266-
txPin = txPin < 0 ? TX1 : txPin;
271+
if (rxPin < 0 && txPin < 0) {
272+
rxPin = RX1;
273+
txPin = TX1;
274+
}
267275
break;
268276
#endif
269277
#if SOC_UART_NUM > 2 // may save some flash bytes...
270278
case UART_NUM_2:
271-
rxPin = rxPin < 0 ? RX2 : rxPin;
272-
txPin = txPin < 0 ? TX2 : txPin;
279+
if (rxPin < 0 && txPin < 0) {
280+
rxPin = RX2;
281+
txPin = TX2;
282+
}
273283
break;
274284
#endif
275285
default:

0 commit comments

Comments
 (0)