Merge pull request #1822 from tarlepp/feat/readonly-services

Feat - Introduce `readonly` services

Author: tarlepp

src/ArgumentResolver/EntityValueResolver.php

@@ -42,7 +42,7 @@
 class EntityValueResolver implements ArgumentValueResolverInterface
 {
     public function __construct(
-        private ResourceCollection $resourceCollection,
+        private readonly ResourceCollection $resourceCollection,
     ) {
     }
 

src/ArgumentResolver/LoggedInUserValueResolver.php

@@ -38,7 +38,7 @@
 class LoggedInUserValueResolver implements ArgumentValueResolverInterface
 {
     public function __construct(
-        private UserTypeIdentification $userService,
+        private readonly UserTypeIdentification $userService,
     ) {
     }
 

src/ArgumentResolver/RestDtoValueResolver.php

@@ -59,8 +59,8 @@ class RestDtoValueResolver implements ArgumentValueResolverInterface
      * @param ControllerCollection<Controller> $controllerCollection
      */
     public function __construct(
-        private ControllerCollection $controllerCollection,
-        private AutoMapperInterface $autoMapper,
+        private readonly ControllerCollection $controllerCollection,
+        private readonly AutoMapperInterface $autoMapper,
     ) {
     }
 

src/AutoMapper/ApiKey/AutoMapperConfiguration.php

@@ -33,7 +33,7 @@ class AutoMapperConfiguration extends RestAutoMapperConfiguration
     ];
 
     public function __construct(
-        protected RequestMapper $requestMapper,
+        protected readonly RequestMapper $requestMapper,
     ) {
     }
 }

src/AutoMapper/ApiKey/RequestMapper.php

@@ -33,7 +33,7 @@ class RequestMapper extends RestRequestMapper
     ];
 
     public function __construct(
-        private UserGroupResource $userGroupResource,
+        private readonly UserGroupResource $userGroupResource,
     ) {
     }
 

src/AutoMapper/User/AutoMapperConfiguration.php

@@ -33,7 +33,7 @@ class AutoMapperConfiguration extends RestAutoMapperConfiguration
     ];
 
     public function __construct(
-        protected RequestMapper $requestMapper,
+        protected readonly RequestMapper $requestMapper,
     ) {
     }
 }

src/AutoMapper/User/RequestMapper.php

@@ -38,7 +38,7 @@ class RequestMapper extends RestRequestMapper
     ];
 
     public function __construct(
-        private UserGroupResource $userGroupResource,
+        private readonly UserGroupResource $userGroupResource,
     ) {
     }
 

src/AutoMapper/UserGroup/AutoMapperConfiguration.php

@@ -33,7 +33,7 @@ class AutoMapperConfiguration extends RestAutoMapperConfiguration
     ];
 
     public function __construct(
-        protected RequestMapper $requestMapper,
+        protected readonly RequestMapper $requestMapper,
     ) {
     }
 }

src/AutoMapper/UserGroup/RequestMapper.php

@@ -30,7 +30,7 @@ class RequestMapper extends RestRequestMapper
     ];
 
     public function __construct(
-        private RoleResource $roleResource,
+        private readonly RoleResource $roleResource,
     ) {
     }
 

src/Command/ApiKey/ApiKeyHelper.php

@@ -27,8 +27,8 @@
 class ApiKeyHelper
 {
     public function __construct(
-        private ApiKeyResource $apiKeyResource,
-        private RolesService $rolesService,
+        private readonly ApiKeyResource $apiKeyResource,
+        private readonly RolesService $rolesService,
     ) {
     }
 

src/Command/ApiKey/ChangeTokenCommand.php

@@ -34,8 +34,8 @@ class ChangeTokenCommand extends Command
     public const NAME = 'api-key:change-token';
 
     public function __construct(
-        private ApiKeyResource $apiKeyResource,
-        private ApiKeyHelper $apiKeyHelper,
+        private readonly ApiKeyResource $apiKeyResource,
+        private readonly ApiKeyHelper $apiKeyHelper,
     ) {
         parent::__construct();
     }

src/Command/ApiKey/CreateApiKeyCommand.php

@@ -53,11 +53,11 @@ class CreateApiKeyCommand extends Command
     ];
 
     public function __construct(
-        private ApiKeyHelper $apiKeyHelper,
-        private ApiKeyResource $apiKeyResource,
-        private UserGroupResource $userGroupResource,
-        private RolesService $rolesService,
-        private RoleRepository $roleRepository,
+        private readonly ApiKeyHelper $apiKeyHelper,
+        private readonly ApiKeyResource $apiKeyResource,
+        private readonly UserGroupResource $userGroupResource,
+        private readonly RolesService $rolesService,
+        private readonly RoleRepository $roleRepository,
     ) {
         parent::__construct();
     }

src/Command/ApiKey/EditApiKeyCommand.php

@@ -37,8 +37,8 @@ class EditApiKeyCommand extends Command
     public const NAME = 'api-key:edit';
 
     public function __construct(
-        private ApiKeyResource $apiKeyResource,
-        private ApiKeyHelper $apiKeyHelper,
+        private readonly ApiKeyResource $apiKeyResource,
+        private readonly ApiKeyHelper $apiKeyHelper,
     ) {
         parent::__construct();
     }

src/Command/ApiKey/ListApiKeysCommand.php

@@ -38,8 +38,8 @@ class ListApiKeysCommand extends Command
     public const NAME = 'api-key:list';
 
     public function __construct(
-        private ApiKeyResource $apiKeyResource,
-        private RolesService $rolesService,
+        private readonly ApiKeyResource $apiKeyResource,
+        private readonly RolesService $rolesService,
     ) {
         parent::__construct();
     }

src/Command/ApiKey/RemoveApiKeyCommand.php

@@ -34,8 +34,8 @@ class RemoveApiKeyCommand extends Command
     public const NAME = 'api-key:remove';
 
     public function __construct(
-        private ApiKeyResource $apiKeyResource,
-        private ApiKeyHelper $apiKeyHelper,
+        private readonly ApiKeyResource $apiKeyResource,
+        private readonly ApiKeyHelper $apiKeyHelper,
     ) {
         parent::__construct();
     }

src/Command/User/CreateRolesCommand.php

@@ -39,9 +39,9 @@ class CreateRolesCommand extends Command
     public const NAME = 'user:create-roles';
 
     public function __construct(
-        private EntityManagerInterface $entityManager,
-        private RoleRepository $roleRepository,
-        private RolesService $rolesService,
+        private readonly EntityManagerInterface $entityManager,
+        private readonly RoleRepository $roleRepository,
+        private readonly RolesService $rolesService,
     ) {
         parent::__construct();
     }

src/Command/User/CreateUserCommand.php

@@ -76,10 +76,10 @@ class CreateUserCommand extends Command
     ];
 
     public function __construct(
-        private UserResource $userResource,
-        private UserGroupResource $userGroupResource,
-        private RolesService $rolesService,
-        private RoleRepository $roleRepository,
+        private readonly UserResource $userResource,
+        private readonly UserGroupResource $userGroupResource,
+        private readonly RolesService $rolesService,
+        private readonly RoleRepository $roleRepository,
     ) {
         parent::__construct();
     }

src/Command/User/CreateUserGroupCommand.php

@@ -56,8 +56,8 @@ class CreateUserGroupCommand extends Command
     ];
 
     public function __construct(
-        private UserGroupResource $userGroupResource,
-        private RoleRepository $roleRepository,
+        private readonly UserGroupResource $userGroupResource,
+        private readonly RoleRepository $roleRepository,
     ) {
         parent::__construct();
     }

src/Command/User/EditUserCommand.php

@@ -37,8 +37,8 @@ class EditUserCommand extends Command
     public const NAME = 'user:edit';
 
     public function __construct(
-        private UserResource $userResource,
-        private UserHelper $userHelper,
+        private readonly UserResource $userResource,
+        private readonly UserHelper $userHelper,
     ) {
         parent::__construct();
     }

src/Command/User/EditUserGroupCommand.php

@@ -37,8 +37,8 @@ class EditUserGroupCommand extends Command
     public const NAME = 'user:edit-group';
 
     public function __construct(
-        private UserGroupResource $userGroupResource,
-        private UserHelper $userHelper,
+        private readonly UserGroupResource $userGroupResource,
+        private readonly UserHelper $userHelper,
     ) {
         parent::__construct();
     }

src/Command/User/ListUserGroupsCommand.php

@@ -39,7 +39,7 @@ class ListUserGroupsCommand extends Command
     public const NAME = 'user:list-groups';
 
     public function __construct(
-        private UserGroupResource $userGroupResource,
+        private readonly UserGroupResource $userGroupResource,
     ) {
         parent::__construct();
     }

src/Command/User/ListUsersCommand.php

@@ -40,8 +40,8 @@ class ListUsersCommand extends Command
     public const NAME = 'user:list';
 
     public function __construct(
-        private UserResource $userResource,
-        private RolesService $roles,
+        private readonly UserResource $userResource,
+        private readonly RolesService $roles,
     ) {
         parent::__construct();
     }

src/Command/User/RemoveUserCommand.php

@@ -34,8 +34,8 @@ class RemoveUserCommand extends Command
     public const NAME = 'user:remove';
 
     public function __construct(
-        private UserResource $userResource,
-        private UserHelper $userHelper,
+        private readonly UserResource $userResource,
+        private readonly UserHelper $userHelper,
     ) {
         parent::__construct();
     }

src/Command/User/RemoveUserGroupCommand.php

@@ -34,8 +34,8 @@ class RemoveUserGroupCommand extends Command
     public const NAME = 'user:remove-group';
 
     public function __construct(
-        private UserGroupResource $userGroupResource,
-        private UserHelper $userHelper,
+        private readonly UserGroupResource $userGroupResource,
+        private readonly UserHelper $userHelper,
     ) {
         parent::__construct();
     }

src/Command/User/UserHelper.php

@@ -27,8 +27,8 @@
 class UserHelper
 {
     public function __construct(
-        private UserResource $userResource,
-        private UserGroupResource $userGroupResource,
+        private readonly UserResource $userResource,
+        private readonly UserGroupResource $userGroupResource,
     ) {
     }
 

src/Command/Utils/CheckDependencies.php

@@ -57,7 +57,7 @@ class CheckDependencies extends Command
     use SymfonyStyleTrait;
 
     public function __construct(
-        private string $projectDir,
+        private readonly string $projectDir,
     ) {
         parent::__construct();
 

src/Command/Utils/CreateDateDimensionEntitiesCommand.php

@@ -41,7 +41,7 @@ class CreateDateDimensionEntitiesCommand extends Command
     private const YEAR_MAX = 2047; // This should be the year when I'm officially retired
 
     public function __construct(
-        private DateDimensionRepository $dateDimensionRepository,
+        private readonly DateDimensionRepository $dateDimensionRepository,
     ) {
         parent::__construct();
     }

src/Controller/HealthzController.php

@@ -26,8 +26,8 @@
 class HealthzController
 {
     public function __construct(
-        private ResponseHandler $responseHandler,
-        private HealthzService $healthzService,
+        private readonly ResponseHandler $responseHandler,
+        private readonly HealthzService $healthzService,
     ) {
     }
 

src/Controller/VersionController.php

@@ -23,7 +23,7 @@
 class VersionController
 {
     public function __construct(
-        private Version $version,
+        private readonly Version $version,
     ) {
     }
 

src/Controller/v1/Localization/LanguageController.php

@@ -25,7 +25,7 @@
 class LanguageController
 {
     public function __construct(
-        private Localization $localization,
+        private readonly Localization $localization,
     ) {
     }
 

src/Controller/v1/Localization/LocaleController.php

@@ -25,7 +25,7 @@
 class LocaleController
 {
     public function __construct(
-        private Localization $localization,
+        private readonly Localization $localization,
     ) {
     }
 

src/Controller/v1/Localization/TimeZoneController.php

@@ -25,7 +25,7 @@
 class TimeZoneController
 {
     public function __construct(
-        private Localization $localization,
+        private readonly Localization $localization,
     ) {
     }
 

src/Controller/v1/Profile/GroupsController.php

@@ -28,7 +28,7 @@
 class GroupsController
 {
     public function __construct(
-        private SerializerInterface $serializer,
+        private readonly SerializerInterface $serializer,
     ) {
     }
 

src/Controller/v1/Profile/IndexController.php

@@ -30,8 +30,8 @@
 class IndexController
 {
     public function __construct(
-        private SerializerInterface $serializer,
-        private RolesService $rolesService,
+        private readonly SerializerInterface $serializer,
+        private readonly RolesService $rolesService,
     ) {
     }
 

src/Controller/v1/Profile/RolesController.php

@@ -26,7 +26,7 @@
 class RolesController
 {
     public function __construct(
-        private RolesService $rolesService,
+        private readonly RolesService $rolesService,
     ) {
     }
 

src/Controller/v1/Role/InheritedRolesController.php

@@ -30,7 +30,7 @@
 class InheritedRolesController
 {
     public function __construct(
-        private RolesService $rolesService,
+        private readonly RolesService $rolesService,
     ) {
     }
 

src/Controller/v1/User/AttachUserGroupController.php

@@ -33,9 +33,9 @@
 class AttachUserGroupController
 {
     public function __construct(
-        private UserResource $userResource,
-        private UserGroupResource $userGroupResource,
-        private SerializerInterface $serializer,
+        private readonly UserResource $userResource,
+        private readonly UserGroupResource $userGroupResource,
+        private readonly SerializerInterface $serializer,
     ) {
     }
 

src/Controller/v1/User/DetachUserGroupController.php

@@ -32,9 +32,9 @@
 class DetachUserGroupController
 {
     public function __construct(
-        private UserResource $userResource,
-        private UserGroupResource $userGroupResource,
-        private SerializerInterface $serializer,
+        private readonly UserResource $userResource,
+        private readonly UserGroupResource $userGroupResource,
+        private readonly SerializerInterface $serializer,
     ) {
     }