Skip to content

Commit 8e266db

Browse files
deps: bump msgpack requirement to 1.0.4
In this patch we bump msgpack requirement since version 1.0.4 has various vulnerability fixes (for example, [1]). Since the code is still compatible with msgpack-python and older msgpack, tests are not removed in this patch. 1. msgpack/msgpack-python#153
1 parent 60a2f38 commit 8e266db

File tree

3 files changed

+14
-3
lines changed

3 files changed

+14
-3
lines changed

.github/workflows/testing.yml

Lines changed: 12 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,7 @@ jobs:
5353
msgpack-deps: 'msgpack==0.6.2'
5454
- tarantool: '2.8'
5555
python: '3.10'
56-
msgpack-deps: 'msgpack==1.0.0'
56+
msgpack-deps: 'msgpack==1.0.4'
5757

5858
steps:
5959
- name: Clone the connector
@@ -91,6 +91,17 @@ jobs:
9191
pip install ${{ matrix.msgpack-deps }}
9292
sed -i -e "s/^msgpack.*$/${{ matrix.msgpack-deps }}/" requirements.txt
9393
94+
- name: Install specific version of msgpack package
95+
# We want to enforce using modern msgpack since it has
96+
# various vulnerability fixes. But the code is compatible
97+
# with older msgpack versions. To this test compatibility
98+
# we must ignore requirements.txt install of the newer msgpack
99+
# package by overwriting it with sed.
100+
if: startsWith(matrix.msgpack-deps, 'msgpack==') == true
101+
run: |
102+
pip install ${{ matrix.msgpack-deps }}
103+
sed -i -e "s/^msgpack.*$/${{ matrix.msgpack-deps }}/" requirements.txt
104+
94105
- name: Install package requirements
95106
run: pip install -r requirements.txt
96107

requirements.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
msgpack>=0.4.0
1+
msgpack>=1.0.4

setup.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -83,7 +83,7 @@ def find_version(*file_paths):
8383
cmdclass=cmdclass,
8484
command_options=command_options,
8585
install_requires=[
86-
'msgpack>=0.4.0',
86+
'msgpack>=1.0.4',
8787
],
8888
python_requires='>=3',
8989
)

0 commit comments

Comments
 (0)