Extract JDBC holdability check

Author: nicktorwald

src/main/java/org/tarantool/jdbc/SQLConnection.java

@@ -9,6 +9,7 @@
 import org.tarantool.CommunicationException;
 import org.tarantool.JDBCBridge;
 import org.tarantool.TarantoolConnection;
+import org.tarantool.util.JdbcConstants;
 import org.tarantool.util.SQLStates;
 
 import java.io.IOException;
@@ -40,7 +41,6 @@
 import java.util.Properties;
 import java.util.concurrent.Executor;
 
-@SuppressWarnings("Since15")
 public class SQLConnection implements Connection {
 
     private static final int UNSET_HOLDABILITY = 0;
@@ -593,10 +593,7 @@ private void handleException(Exception e) {
      * @throws SQLNonTransientException        param has invalid value
      */
     private void checkHoldabilitySupport(int holdability) throws SQLException {
-        if (holdability != ResultSet.CLOSE_CURSORS_AT_COMMIT &&
-            holdability != ResultSet.HOLD_CURSORS_OVER_COMMIT) {
-            throw new SQLNonTransientException("", SQLStates.INVALID_PARAMETER_VALUE.getSqlState());
-        }
+        JdbcConstants.checkHoldabilityConstant(holdability);
         if (!getMetaData().supportsResultSetHoldability(holdability)) {
             throw new SQLFeatureNotSupportedException();
         }
@@ -613,4 +610,5 @@ private void checkHoldabilitySupport(int holdability) throws SQLException {
     private static String formatError(String sql, Object... params) {
         return "Failed to execute SQL: " + sql + ", params: " + Arrays.deepToString(params);
     }
+
 }

src/main/java/org/tarantool/util/JdbcConstants.java

@@ -0,0 +1,16 @@
+package org.tarantool.util;
+
+import java.sql.ResultSet;
+import java.sql.SQLException;
+import java.sql.SQLNonTransientException;
+
+public class JdbcConstants {
+
+    public static void checkHoldabilityConstant(int holdability) throws SQLException {
+        if (holdability != ResultSet.CLOSE_CURSORS_AT_COMMIT &&
+            holdability != ResultSet.HOLD_CURSORS_OVER_COMMIT) {
+            throw new SQLNonTransientException("", SQLStates.INVALID_PARAMETER_VALUE.getSqlState());
+        }
+    }
+
+}