resolve questionable code

Author: DifferentialOrange

settings/request.go

@@ -63,216 +63,211 @@ import (
 	"github.com/tarantool/go-tarantool"
 )
 
-// Request helps to work with session settings.
-type Request struct {
-	get *tarantool.SelectRequest
-	set *tarantool.UpdateRequest
+// SetRequest helps to set session settings.
+type SetRequest struct {
+	impl *tarantool.UpdateRequest
 }
 
-func (req *Request) assertBuiltWithNew() {
-	if (req.get == nil) && (req.set == nil) {
-		panic("Invalid settings.Request (empty), possibly build not with New*Request function")
-	}
-
-	if (req.get != nil) && (req.set != nil) {
-		panic("Invalid settings.Request (both types), possibly build not with New*Request function")
-	}
-}
-
-func newSetRequest(setting string, value interface{}) *Request {
-	return &Request{
-		set: tarantool.NewUpdateRequest(sessionSettingsSpace).
+func newSetRequest(setting string, value interface{}) *SetRequest {
+	return &SetRequest{
+		impl: tarantool.NewUpdateRequest(sessionSettingsSpace).
 			Key(tarantool.StringKey{S: setting}).
 			Operations(tarantool.NewOperations().Assign(sessionSettingValueField, value)),
 	}
 }
 
-func newGetRequest(setting string) *Request {
-	return &Request{
-		get: tarantool.NewSelectRequest(sessionSettingsSpace).
-			Key(tarantool.StringKey{S: setting}).
-			Limit(1),
-	}
+// Context sets a passed context to set session settings request.
+func (req *SetRequest) Context(ctx context.Context) *SetRequest {
+	req.impl = req.impl.Context(ctx)
+
+	return req
 }
 
-// Context sets a passed context to the session settings request.
-func (req *Request) Context(ctx context.Context) *Request {
-	req.assertBuiltWithNew()
+// Code returns IPROTO code for set session settings request.
+func (req *SetRequest) Code() int32 {
+	return req.impl.Code()
+}
 
-	if req.set != nil {
-		req.set = req.set.Context(ctx)
-	} else {
-		req.get = req.get.Context(ctx)
-	}
+// Body fills an encoder with set session settings request body.
+func (req *SetRequest) Body(res tarantool.SchemaResolver, enc *encoder) error {
+	return req.impl.Body(res, enc)
+}
 
-	return req
+// Ctx returns a context of set session settings request.
+func (req *SetRequest) Ctx() context.Context {
+	return req.impl.Ctx()
+}
+
+// Async returns is set session settings request expects a response.
+func (req *SetRequest) Async() bool {
+	return req.impl.Async()
 }
 
-// Code returns IPROTO code for the session settings request.
-func (req *Request) Code() int32 {
-	req.assertBuiltWithNew()
+// GetRequest helps to get session settings.
+type GetRequest struct {
+	impl *tarantool.SelectRequest
+}
 
-	if req.set != nil {
-		return req.set.Code()
+func newGetRequest(setting string) *GetRequest {
+	return &GetRequest{
+		impl: tarantool.NewSelectRequest(sessionSettingsSpace).
+			Key(tarantool.StringKey{S: setting}).
+			Limit(1),
 	}
-	return req.get.Code()
 }
 
-// Body fills an encoder with the session settings request body.
-func (req *Request) Body(res tarantool.SchemaResolver, enc *encoder) error {
-	req.assertBuiltWithNew()
+// Context sets a passed context to get session settings request.
+func (req *GetRequest) Context(ctx context.Context) *GetRequest {
+	req.impl = req.impl.Context(ctx)
 
-	if req.set != nil {
-		return req.set.Body(res, enc)
-	}
-	return req.get.Body(res, enc)
+	return req
 }
 
-// Ctx returns a context of the session settings request.
-func (req *Request) Ctx() context.Context {
-	req.assertBuiltWithNew()
+// Code returns IPROTO code for get session settings request.
+func (req *GetRequest) Code() int32 {
+	return req.impl.Code()
+}
 
-	if req.set != nil {
-		return req.set.Ctx()
-	}
-	return req.get.Ctx()
+// Body fills an encoder with get session settings request body.
+func (req *GetRequest) Body(res tarantool.SchemaResolver, enc *encoder) error {
+	return req.impl.Body(res, enc)
 }
 
-// Async returns is the session settings request expects a response.
-func (req *Request) Async() bool {
-	req.assertBuiltWithNew()
+// Ctx returns a context of get session settings request.
+func (req *GetRequest) Ctx() context.Context {
+	return req.impl.Ctx()
+}
 
-	if req.set != nil {
-		return req.set.Async()
-	}
-	return req.get.Async()
+// Async returns is get session settings request expects a response.
+func (req *GetRequest) Async() bool {
+	return req.impl.Async()
 }
 
 // NewErrorMarshalingEnabledSetRequest creates a request to
 // update current session ErrorMarshalingEnabled setting.
-func NewErrorMarshalingEnabledSetRequest(value bool) *Request {
+func NewErrorMarshalingEnabledSetRequest(value bool) *SetRequest {
 	return newSetRequest(errorMarshalingEnabled, value)
 }
 
 // NewErrorMarshalingEnabledGetRequest creates a request to get
 // current session ErrorMarshalingEnabled setting in tuple format.
-func NewErrorMarshalingEnabledGetRequest() *Request {
+func NewErrorMarshalingEnabledGetRequest() *GetRequest {
 	return newGetRequest(errorMarshalingEnabled)
 }
 
 // NewSQLDefaultEngineSetRequest creates a request to
 // update current session SQLDefaultEngine setting.
-func NewSQLDefaultEngineSetRequest(value string) *Request {
+func NewSQLDefaultEngineSetRequest(value string) *SetRequest {
 	return newSetRequest(sqlDefaultEngine, value)
 }
 
 // NewSQLDefaultEngineGetRequest creates a request to get
 // current session SQLDefaultEngine setting in tuple format.
-func NewSQLDefaultEngineGetRequest() *Request {
+func NewSQLDefaultEngineGetRequest() *GetRequest {
 	return newGetRequest(sqlDefaultEngine)
 }
 
 // NewSQLDeferForeignKeysSetRequest creates a request to
 // update current session SQLDeferForeignKeys setting.
-func NewSQLDeferForeignKeysSetRequest(value bool) *Request {
+func NewSQLDeferForeignKeysSetRequest(value bool) *SetRequest {
 	return newSetRequest(sqlDeferForeignKeys, value)
 }
 
 // NewSQLDeferForeignKeysGetRequest creates a request to get
 // current session SQLDeferForeignKeys setting in tuple format.
-func NewSQLDeferForeignKeysGetRequest() *Request {
+func NewSQLDeferForeignKeysGetRequest() *GetRequest {
 	return newGetRequest(sqlDeferForeignKeys)
 }
 
 // NewSQLFullColumnNamesSetRequest creates a request to
 // update current session SQLFullColumnNames setting.
-func NewSQLFullColumnNamesSetRequest(value bool) *Request {
+func NewSQLFullColumnNamesSetRequest(value bool) *SetRequest {
 	return newSetRequest(sqlFullColumnNames, value)
 }
 
 // NewSQLFullColumnNamesGetRequest creates a request to get
 // current session SQLFullColumnNames setting in tuple format.
-func NewSQLFullColumnNamesGetRequest() *Request {
+func NewSQLFullColumnNamesGetRequest() *GetRequest {
 	return newGetRequest(sqlFullColumnNames)
 }
 
 // NewSQLFullMetadataSetRequest creates a request to
 // update current session SQLFullMetadata setting.
-func NewSQLFullMetadataSetRequest(value bool) *Request {
+func NewSQLFullMetadataSetRequest(value bool) *SetRequest {
 	return newSetRequest(sqlFullMetadata, value)
 }
 
 // NewSQLFullMetadataGetRequest creates a request to get
 // current session SQLFullMetadata setting in tuple format.
-func NewSQLFullMetadataGetRequest() *Request {
+func NewSQLFullMetadataGetRequest() *GetRequest {
 	return newGetRequest(sqlFullMetadata)
 }
 
 // NewSQLParserDebugSetRequest creates a request to
 // update current session SQLParserDebug setting.
-func NewSQLParserDebugSetRequest(value bool) *Request {
+func NewSQLParserDebugSetRequest(value bool) *SetRequest {
 	return newSetRequest(sqlParserDebug, value)
 }
 
 // NewSQLParserDebugGetRequest creates a request to get
 // current session SQLParserDebug setting in tuple format.
-func NewSQLParserDebugGetRequest() *Request {
+func NewSQLParserDebugGetRequest() *GetRequest {
 	return newGetRequest(sqlParserDebug)
 }
 
 // NewSQLRecursiveTriggersSetRequest creates a request to
 // update current session SQLRecursiveTriggers setting.
-func NewSQLRecursiveTriggersSetRequest(value bool) *Request {
+func NewSQLRecursiveTriggersSetRequest(value bool) *SetRequest {
 	return newSetRequest(sqlRecursiveTriggers, value)
 }
 
 // NewSQLRecursiveTriggersGetRequest creates a request to get
 // current session SQLRecursiveTriggers setting in tuple format.
-func NewSQLRecursiveTriggersGetRequest() *Request {
+func NewSQLRecursiveTriggersGetRequest() *GetRequest {
 	return newGetRequest(sqlRecursiveTriggers)
 }
 
 // NewSQLReverseUnorderedSelectsSetRequest creates a request to
 // update current session SQLReverseUnorderedSelects setting.
-func NewSQLReverseUnorderedSelectsSetRequest(value bool) *Request {
+func NewSQLReverseUnorderedSelectsSetRequest(value bool) *SetRequest {
 	return newSetRequest(sqlReverseUnorderedSelects, value)
 }
 
 // NewSQLReverseUnorderedSelectsGetRequest creates a request to get
 // current session SQLReverseUnorderedSelects setting in tuple format.
-func NewSQLReverseUnorderedSelectsGetRequest() *Request {
+func NewSQLReverseUnorderedSelectsGetRequest() *GetRequest {
 	return newGetRequest(sqlReverseUnorderedSelects)
 }
 
 // NewSQLSelectDebugSetRequest creates a request to
 // update current session SQLSelectDebug setting.
-func NewSQLSelectDebugSetRequest(value bool) *Request {
+func NewSQLSelectDebugSetRequest(value bool) *SetRequest {
 	return newSetRequest(sqlSelectDebug, value)
 }
 
 // NewSQLSelectDebugGetRequest creates a request to get
 // current session SQLSelectDebug setting in tuple format.
-func NewSQLSelectDebugGetRequest() *Request {
+func NewSQLSelectDebugGetRequest() *GetRequest {
 	return newGetRequest(sqlSelectDebug)
 }
 
 // NewSQLVDBEDebugSetRequest creates a request to
 // update current session SQLVDBEDebug setting.
-func NewSQLVDBEDebugSetRequest(value bool) *Request {
+func NewSQLVDBEDebugSetRequest(value bool) *SetRequest {
 	return newSetRequest(sqlVDBEDebug, value)
 }
 
 // NewSQLVDBEDebugGetRequest creates a request to get
 // current session SQLVDBEDebug setting in tuple format.
-func NewSQLVDBEDebugGetRequest() *Request {
+func NewSQLVDBEDebugGetRequest() *GetRequest {
 	return newGetRequest(sqlVDBEDebug)
 }
 
 // NewSessionSettingsGetRequest creates a request to get all
 // current session settings in tuple format.
-func NewSessionSettingsGetRequest() *Request {
-	return &Request{
-		get: tarantool.NewSelectRequest(sessionSettingsSpace).
+func NewSessionSettingsGetRequest() *GetRequest {
+	return &GetRequest{
+		impl: tarantool.NewSelectRequest(sessionSettingsSpace).
 			Limit(selectAllLimit),
 	}
 }