Skip to content

Commit 30e397d

Browse files
committed
CI: disable Windows runner
Disabling of the Windows runner. These tests were flaking. Because we don't support connector on Windows, I considered disabling these tests. Part of #10
1 parent 5bb944e commit 30e397d

File tree

3 files changed

+3
-26
lines changed

3 files changed

+3
-26
lines changed

.github/actions/go-test-setup/action.yml

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -7,13 +7,6 @@ runs:
77
shell: bash
88
run: |
99
echo 'CGO_ENABLED=1' >> $GITHUB_ENV
10-
- name: Windows setup
11-
shell: bash
12-
if: ${{ runner.os == 'Windows' }}
13-
run: |
14-
pacman -S --noconfirm mingw-w64-x86_64-toolchain mingw-w64-i686-toolchain
15-
echo '/c/msys64/mingw64/bin' >> $GITHUB_PATH
16-
echo 'PATH_386=/c/msys64/mingw32/bin:${{ env.PATH_386 }}' >> $GITHUB_ENV
1710
- name: Linux setup
1811
shell: bash
1912
if: ${{ runner.os == 'Linux' }}

.github/workflows/go-test-ubuntu-22.04.yml

Lines changed: 1 addition & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -27,14 +27,6 @@ jobs:
2727
run: |
2828
go version
2929
go env
30-
- name: Use msys2 on windows
31-
if: startsWith(matrix.os, 'windows')
32-
shell: bash
33-
# The executable for msys2 is also called bash.cmd
34-
# https://github.com/actions/virtual-environments/blob/main/images/win/Windows2019-Readme.md#shells
35-
# If we prepend its location to the PATH
36-
# subsequent 'shell: bash' steps will use msys2 instead of gitbash
37-
run: echo "C:/msys64/usr/bin" >> $GITHUB_PATH
3830
- name: Run repo-specific setup
3931
uses: ./.github/actions/go-test-setup
4032
if: hashFiles('./.github/actions/go-test-setup') != ''
@@ -55,7 +47,7 @@ jobs:
5547
export "PATH=${{ env.PATH_386 }}:$PATH"
5648
go test -v ./...
5749
- name: Run tests with race detector
58-
if: startsWith(matrix.os, 'ubuntu') # speed things up. Windows and OSX VMs are slow
50+
if: startsWith(matrix.os, 'ubuntu') # speed things up. OSX VMs is slow
5951
uses: protocol/multiple-go-modules@v1.2
6052
with:
6153
run: go test -v -race ./...

.github/workflows/go-test.yml

Lines changed: 2 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ jobs:
99
strategy:
1010
fail-fast: false
1111
matrix:
12-
os: [ "ubuntu", "windows", "macos" ]
12+
os: [ "ubuntu", "macos" ]
1313
go: [ "1.18.x", "1.19.x" ]
1414
env:
1515
COVERAGES: ""
@@ -26,14 +26,6 @@ jobs:
2626
run: |
2727
go version
2828
go env
29-
- name: Use msys2 on windows
30-
if: ${{ matrix.os == 'windows' }}
31-
shell: bash
32-
# The executable for msys2 is also called bash.cmd
33-
# https://github.com/actions/virtual-environments/blob/main/images/win/Windows2019-Readme.md#shells
34-
# If we prepend its location to the PATH
35-
# subsequent 'shell: bash' steps will use msys2 instead of gitbash
36-
run: echo "C:/msys64/usr/bin" >> $GITHUB_PATH
3729
- name: Run repo-specific setup
3830
uses: ./.github/actions/go-test-setup
3931
if: hashFiles('./.github/actions/go-test-setup') != ''
@@ -54,7 +46,7 @@ jobs:
5446
export "PATH=${{ env.PATH_386 }}:$PATH"
5547
go test -v -shuffle=on ./...
5648
- name: Run tests with race detector
57-
if: ${{ matrix.os == 'ubuntu' }} # speed things up. Windows and OSX VMs are slow
49+
if: ${{ matrix.os == 'ubuntu' }} # speed things up. OSX VMs is slow
5850
uses: protocol/multiple-go-modules@v1.2
5951
with:
6052
run: go test -v -race ./...

0 commit comments

Comments
 (0)