Skip to content

Commit e6edfa8

Browse files
committed
Turn wrappers into value classes and make them final
1 parent 0d14e71 commit e6edfa8

File tree

3 files changed

+15
-15
lines changed

3 files changed

+15
-15
lines changed

src/main/scala/scala/compat/java8/PrimitiveIteratorConversions.scala

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -96,13 +96,13 @@ object PrimitiveIteratorConverters {
9696
}
9797

9898
/** Provides conversions from Java `Iterator` to manually specialized `PrimitiveIterator` variants, when available */
99-
implicit class RichJavaIteratorToPrimitives[A](val underlying: JIterator[A]) extends AnyVal {
99+
implicit final class RichJavaIteratorToPrimitives[A](private val underlying: JIterator[A]) extends AnyVal {
100100
/** Wraps this `java.util.Iterator` as a manually specialized variant, if possible */
101101
def asPrimitive[That](implicit specOp: SpecializerOfIterators[A, That]): That = specOp.fromJava(underlying)
102102
}
103103

104104
/** Provides conversions from Scala `Iterator` to manually specialized `PrimitiveIterator` variants, when available */
105-
implicit class RichIteratorToPrimitives[A](val underlying: Iterator[A]) extends AnyVal {
105+
implicit final class RichIteratorToPrimitives[A](private val underlying: Iterator[A]) extends AnyVal {
106106
/** Wraps this `scala.collection.Iterator` as a manually specialized `java.util.PrimitiveIterator` variant, if possible */
107107
def asPrimitive[That](implicit specOp: SpecializerOfIterators[A, That]): That = specOp.fromScala(underlying)
108108
}

src/main/scala/scala/compat/java8/SpliteratorConverters.scala

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -17,13 +17,13 @@ package SpliteratorConverters {
1717

1818

1919
package object SpliteratorConverters extends SpliteratorConverters.Priority2SpliteratorConverters {
20-
implicit class SpliteratorOfDoubleToStepper(private val underlying: Spliterator.OfDouble) extends AnyVal {
20+
implicit final class SpliteratorOfDoubleToStepper(private val underlying: Spliterator.OfDouble) extends AnyVal {
2121
def stepper: DoubleStepper = Stepper.ofSpliterator(underlying)
2222
}
23-
implicit class SpliteratorOfIntToStepper(private val underlying: Spliterator.OfInt) extends AnyVal {
23+
implicit final class SpliteratorOfIntToStepper(private val underlying: Spliterator.OfInt) extends AnyVal {
2424
def stepper: IntStepper = Stepper.ofSpliterator(underlying)
2525
}
26-
implicit class SpliteratorOfLongToStepper(private val underlying: Spliterator.OfLong) extends AnyVal {
26+
implicit final class SpliteratorOfLongToStepper(private val underlying: Spliterator.OfLong) extends AnyVal {
2727
def stepper: LongStepper = Stepper.ofSpliterator(underlying)
2828
}
2929
}

src/main/scala/scala/compat/java8/StreamConverters.scala

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -208,25 +208,25 @@ extends Priority1StreamConverters
208208
with converterImpl.Priority1StepConverters
209209
with converterImpl.Priority1AccumulatorConverters
210210
{
211-
implicit class EnrichDoubleArrayWithStream(a: Array[Double])
212-
extends MakesSequentialStream[java.lang.Double, DoubleStream] with MakesParallelStream[java.lang.Double, DoubleStream] {
211+
implicit final class EnrichDoubleArrayWithStream(private val a: Array[Double])
212+
extends AnyVal with MakesSequentialStream[java.lang.Double, DoubleStream] with MakesParallelStream[java.lang.Double, DoubleStream] {
213213
def seqStream: DoubleStream = java.util.Arrays.stream(a)
214214
def parStream: DoubleStream = seqStream.parallel
215215
}
216216

217-
implicit class EnrichIntArrayWithStream(a: Array[Int])
218-
extends MakesSequentialStream[java.lang.Integer, IntStream] with MakesParallelStream[java.lang.Integer, IntStream] {
217+
implicit final class EnrichIntArrayWithStream(private val a: Array[Int])
218+
extends AnyVal with MakesSequentialStream[java.lang.Integer, IntStream] with MakesParallelStream[java.lang.Integer, IntStream] {
219219
def seqStream: IntStream = java.util.Arrays.stream(a)
220220
def parStream: IntStream = seqStream.parallel
221221
}
222222

223-
implicit class EnrichLongArrayWithStream(a: Array[Long])
224-
extends MakesSequentialStream[java.lang.Long, LongStream] with MakesParallelStream[java.lang.Long, LongStream] {
223+
implicit final class EnrichLongArrayWithStream(private val a: Array[Long])
224+
extends AnyVal with MakesSequentialStream[java.lang.Long, LongStream] with MakesParallelStream[java.lang.Long, LongStream] {
225225
def seqStream: LongStream = java.util.Arrays.stream(a)
226226
def parStream: LongStream = seqStream.parallel
227227
}
228228

229-
implicit val primitiveAccumulateDoubleStream = new PrimitiveStreamAccumulator[Stream[Double], DoubleAccumulator] {
229+
implicit val primitiveAccumulateDoubleStream = new PrimitiveStreamAccumulator[Stream[Double], DoubleAccumulator] {
230230
def streamAccumulate(stream: Stream[Double]): DoubleAccumulator =
231231
stream.collect(DoubleAccumulator.supplier, DoubleAccumulator.boxedAdder, DoubleAccumulator.merger)
232232
}
@@ -274,7 +274,7 @@ with converterImpl.Priority1AccumulatorConverters
274274
implicit val primitiveUnboxLongStream2 =
275275
primitiveUnboxLongStream.asInstanceOf[PrimitiveStreamUnboxer[java.lang.Long, LongStream]]
276276

277-
implicit class RichDoubleStream(stream: DoubleStream) {
277+
implicit final class RichDoubleStream(private val stream: DoubleStream) extends AnyVal {
278278
def accumulate = stream.collect(DoubleAccumulator.supplier, DoubleAccumulator.adder, DoubleAccumulator.merger)
279279

280280
def toScala[Coll[_]](implicit cbf: collection.generic.CanBuildFrom[Nothing, Double, Coll[Double]]): Coll[Double] = {
@@ -287,7 +287,7 @@ with converterImpl.Priority1AccumulatorConverters
287287
}
288288
}
289289

290-
implicit class RichIntStream(stream: IntStream) {
290+
implicit final class RichIntStream(private val stream: IntStream) extends AnyVal {
291291
def accumulate = stream.collect(IntAccumulator.supplier, IntAccumulator.adder, IntAccumulator.merger)
292292

293293
def toScala[Coll[_]](implicit cbf: collection.generic.CanBuildFrom[Nothing, Int, Coll[Int]]): Coll[Int] = {
@@ -300,7 +300,7 @@ with converterImpl.Priority1AccumulatorConverters
300300
}
301301
}
302302

303-
implicit class RichLongStream(stream: LongStream) {
303+
implicit final class RichLongStream(private val stream: LongStream) extends AnyVal {
304304
def accumulate = stream.collect(LongAccumulator.supplier, LongAccumulator.adder, LongAccumulator.merger)
305305

306306
def toScala[Coll[_]](implicit cbf: collection.generic.CanBuildFrom[Nothing, Long, Coll[Long]]): Coll[Long] = {

0 commit comments

Comments
 (0)