Skip to content

Commit 894cb02

Browse files
committed
Rename parameter in algorithm
1 parent ff52db1 commit 894cb02

File tree

2 files changed

+9
-11
lines changed

2 files changed

+9
-11
lines changed

index.js

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,6 @@ Index.prototype.add = add
1010
Index.prototype.remove = remove
1111

1212
function Index(tree, filter, prop) {
13-
var key
1413
var self
1514

1615
if (!(this instanceof Index)) {
@@ -29,10 +28,9 @@ function Index(tree, filter, prop) {
2928
}
3029

3130
self = this
32-
key = typeof prop === 'string' ? pluck : prop
3331

3432
this.index = new Map()
35-
this.keyfn = key
33+
this.keyfn = typeof prop === 'string' ? pluck : prop
3634

3735
if (tree) {
3836
visit(tree, filter, add)

test.js

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ test('Index', function(t) {
1717
t.deepEqual(
1818
[instance instanceof Index, instance.get(1)],
1919
[true, [node]],
20-
'index(key)'
20+
'index(prop)'
2121
)
2222

2323
instance = new Index('id')
@@ -26,7 +26,7 @@ test('Index', function(t) {
2626
t.deepEqual(
2727
[instance instanceof Index, instance.get(1)],
2828
[true, [node]],
29-
'new Index(key)'
29+
'new Index(prop)'
3030
)
3131

3232
instance = index(keyFn)
@@ -52,31 +52,31 @@ test('Index', function(t) {
5252
t.deepEqual(
5353
[instance instanceof Index, instance.get(1)],
5454
[true, [node, alt]],
55-
'index(tree, key)'
55+
'index(tree, prop)'
5656
)
5757

58-
instance = new Index(tree, keyFn)
58+
instance = new Index(tree, 'id')
5959

6060
t.deepEqual(
6161
[instance instanceof Index, instance.get(1)],
6262
[true, [node, alt]],
63-
'new Index(tree, key)'
63+
'new Index(tree, prop)'
6464
)
6565

6666
instance = index(tree, filter, 'id')
6767

6868
t.deepEqual(
6969
[instance instanceof Index, instance.get(1)],
7070
[true, [node]],
71-
'index(tree, filter, key)'
71+
'index(tree, filter, prop)'
7272
)
7373

74-
instance = new Index(tree, filter, keyFn)
74+
instance = new Index(tree, filter, 'id')
7575

7676
t.deepEqual(
7777
[instance instanceof Index, instance.get(1)],
7878
[true, [node]],
79-
'new Index(tree, filter, key)'
79+
'new Index(tree, filter, prop)'
8080
)
8181

8282
t.end()

0 commit comments

Comments
 (0)